Skip to content

The auto-configured WebFluxConfigurer is unordered so it may override customizations made in a user's WebFluxConfigurer #25302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Feb 16, 2021 · 0 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@wilkinsona
Copy link
Member

Unlike WebMvcAutoConfiguration.WebMvcAutoConfigurationAdapter (a WebMvcConfigurer), WebFluxAutoConfiguration.WebFluxConfig (a WebFluxConfigurer) is unordered. This means that it implicitly has lowest precedence and manes that it's impossible to guarantee that any other WebFluxConfigurer will go after it. Our WebMvcConfigurer is @Order(0). We should consider applying the same order to our WebFluxConfiguer as well.

See #12389 for details of why the ordering was configured on the MVC side. If we agree to make this change, we'll need to think about when we want to make it. Theoretically, changing the ordering will break an application that's relying on the current ordering but I'm not sure how likely that is. FWIW, we made the MVC change early in 2.0.x's life (2.0.1).

@wilkinsona wilkinsona added type: bug A general bug for: team-attention An issue we'd like other members of the team to review labels Feb 16, 2021
@philwebb philwebb added this to the 2.5.x milestone Feb 19, 2021
@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Feb 19, 2021
@wilkinsona wilkinsona changed the title The auto-configured WebFluxConfigurer is unordered so it may override customisations made in a user's WebFluxConfigurer The auto-configured WebFluxConfigurer is unordered so it may override customizations made in a user's WebFluxConfigurer Feb 24, 2021
@wilkinsona wilkinsona self-assigned this Feb 24, 2021
@wilkinsona wilkinsona modified the milestones: 2.5.x, 2.5.0-M3 Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants