Skip to content

Commit 98beea9

Browse files
committed
extmod/vfs_blockdev: Add extended read/write methods.
This commit adds helper functions to call readblocks/writeblocks with a fourth argument, the byte offset within a block. Although the mp_vfs_blockdev_t struct has grown here by 2 machine words, in all current uses of this struct within this repository it still fits within the same number of GC blocks.
1 parent 22bfc47 commit 98beea9

File tree

2 files changed

+35
-2
lines changed

2 files changed

+35
-2
lines changed

extmod/vfs.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ typedef struct _mp_vfs_proto_t {
5959
typedef struct _mp_vfs_blockdev_t {
6060
uint16_t flags;
6161
size_t block_size;
62-
mp_obj_t readblocks[4];
63-
mp_obj_t writeblocks[4];
62+
mp_obj_t readblocks[5];
63+
mp_obj_t writeblocks[5];
6464
// new protocol uses just ioctl, old uses sync (optional) and count
6565
union {
6666
mp_obj_t ioctl[4];
@@ -80,7 +80,9 @@ typedef struct _mp_vfs_mount_t {
8080

8181
void mp_vfs_blockdev_init(mp_vfs_blockdev_t *self, mp_obj_t bdev);
8282
int mp_vfs_blockdev_read(mp_vfs_blockdev_t *self, size_t block_num, size_t num_blocks, uint8_t *buf);
83+
int mp_vfs_blockdev_read_ext(mp_vfs_blockdev_t *self, size_t block_num, size_t block_off, size_t len, uint8_t *buf);
8384
int mp_vfs_blockdev_write(mp_vfs_blockdev_t *self, size_t block_num, size_t num_blocks, const uint8_t *buf);
85+
int mp_vfs_blockdev_write_ext(mp_vfs_blockdev_t *self, size_t block_num, size_t block_off, size_t len, const uint8_t *buf);
8486
mp_obj_t mp_vfs_blockdev_ioctl(mp_vfs_blockdev_t *self, uintptr_t cmd, uintptr_t arg);
8587

8688
mp_vfs_mount_t *mp_vfs_lookup_path(const char *path, const char **path_out);

extmod/vfs_blockdev.c

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,19 @@ int mp_vfs_blockdev_read(mp_vfs_blockdev_t *self, size_t block_num, size_t num_b
6060
}
6161
}
6262

63+
int mp_vfs_blockdev_read_ext(mp_vfs_blockdev_t *self, size_t block_num, size_t block_off, size_t len, uint8_t *buf) {
64+
mp_obj_array_t ar = {{&mp_type_bytearray}, BYTEARRAY_TYPECODE, 0, len, buf};
65+
self->readblocks[2] = MP_OBJ_NEW_SMALL_INT(block_num);
66+
self->readblocks[3] = MP_OBJ_FROM_PTR(&ar);
67+
self->readblocks[4] = MP_OBJ_NEW_SMALL_INT(block_off);
68+
mp_obj_t ret = mp_call_method_n_kw(3, 0, self->readblocks);
69+
if (ret == mp_const_none) {
70+
return 0;
71+
} else {
72+
return MP_OBJ_SMALL_INT_VALUE(ret);
73+
}
74+
}
75+
6376
int mp_vfs_blockdev_write(mp_vfs_blockdev_t *self, size_t block_num, size_t num_blocks, const uint8_t *buf) {
6477
if (self->writeblocks[0] == MP_OBJ_NULL) {
6578
// read-only block device
@@ -79,6 +92,24 @@ int mp_vfs_blockdev_write(mp_vfs_blockdev_t *self, size_t block_num, size_t num_
7992
}
8093
}
8194

95+
int mp_vfs_blockdev_write_ext(mp_vfs_blockdev_t *self, size_t block_num, size_t block_off, size_t len, const uint8_t *buf) {
96+
if (self->writeblocks[0] == MP_OBJ_NULL) {
97+
// read-only block device
98+
return -MP_EROFS;
99+
}
100+
101+
mp_obj_array_t ar = {{&mp_type_bytearray}, BYTEARRAY_TYPECODE, 0, len, (void*)buf};
102+
self->writeblocks[2] = MP_OBJ_NEW_SMALL_INT(block_num);
103+
self->writeblocks[3] = MP_OBJ_FROM_PTR(&ar);
104+
self->writeblocks[4] = MP_OBJ_NEW_SMALL_INT(block_off);
105+
mp_obj_t ret = mp_call_method_n_kw(3, 0, self->writeblocks);
106+
if (ret == mp_const_none) {
107+
return 0;
108+
} else {
109+
return MP_OBJ_SMALL_INT_VALUE(ret);
110+
}
111+
}
112+
82113
mp_obj_t mp_vfs_blockdev_ioctl(mp_vfs_blockdev_t *self, uintptr_t cmd, uintptr_t arg) {
83114
if (self->flags & MP_BLOCKDEV_FLAG_HAVE_IOCTL) {
84115
// New protocol with ioctl

0 commit comments

Comments
 (0)