Skip to content

Commit f8dfd13

Browse files
authored
[chore][ci]auto-instrumentation: remove ubuntu-20.04 GH runner (#6087)
* [chore][ci]auto-instrumentation: remove ubuntu-20.04 GH runner * Remove amazonlinux-2 * Remove amazonlinux-2
1 parent 1adaeb4 commit f8dfd13

File tree

4 files changed

+5
-89
lines changed

4 files changed

+5
-89
lines changed

.github/workflows/auto-instrumentation.yml

+3-15
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ jobs:
8686
id: get-matrix
8787
run: |
8888
# create test matrix for distro and arch
89-
dockerfiles=$(find packaging/tests/instrumentation/images/ -name "Dockerfile.*" | cut -d '.' -f2- | sort -u)
89+
dockerfiles=$(find packaging/tests/instrumentation/images -name "Dockerfile.*" | cut -d '.' -f2- | sort -u)
9090
if [ -z "$dockerfiles" ]; then
9191
echo "Failed to get dockerfiles from packaging/tests/instrumentation/images!" >&2
9292
exit 1
@@ -95,19 +95,15 @@ jobs:
9595
arch="\"amd64\", \"arm64\""
9696
testcase="\"express\",\"tomcat\",\"dotnet\""
9797
# splunk-otel-dotnet currently not supported on arm64
98-
# amazonlinux-2 requires cgroup v1, only available on version 20.04 that doesn't have an arm runner
99-
exclude='{"ARCH": "arm64", "TESTCASE": "dotnet"},{"DISTRO": "amazonlinux-2", "ARCH": "arm64"}'
98+
exclude='{"ARCH": "arm64", "TESTCASE": "dotnet"}'
10099
matrix="{\"DISTRO\": [${distro%,}], \"ARCH\": [${arch}], \"TESTCASE\": [${testcase}], \"exclude\": [${exclude}]}"
101100
echo "$matrix" | jq
102101
echo "matrix=${matrix}" >> $GITHUB_OUTPUT
103102
outputs:
104103
matrix: ${{ steps.get-matrix.outputs.matrix }}
105104

106105
test-package:
107-
# Amazon Linux 2 uses cgroup v1
108-
# Ubuntu 24.04 uses cgroup v2
109-
# Fallback to Ubuntu 20.04 when appropriate
110-
runs-on: ubuntu-${{ matrix.DISTRO != 'amazonlinux-2' && '24.04' || '20.04' }}${{ matrix.ARCH == 'arm64' && '-arm' || '' }}
106+
runs-on: ubuntu-24.04${{ matrix.ARCH == 'arm64' && '-arm' || '' }}
111107
timeout-minutes: 60
112108
needs: [cross-compile, build-package, test-package-matrix]
113109
strategy:
@@ -160,10 +156,6 @@ jobs:
160156
continue-on-error: true
161157
run: |
162158
distro="${{ matrix.DISTRO }}"
163-
if [[ "$distro" = "amazonlinux-2" ]]; then
164-
# workaround for pytest substring matching
165-
distro="amazonlinux-2 and not amazonlinux-2023"
166-
fi
167159
testcase="${{ matrix.TESTCASE }} or uninstall"
168160
python3 -u -m pytest -s --verbose -k "$distro and ${{ matrix.ARCH }} and ($testcase)" \
169161
packaging/tests/instrumentation/instrumentation_test.py
@@ -173,10 +165,6 @@ jobs:
173165
if: ${{ steps.pytest.outcome == 'failure' }}
174166
run: |
175167
distro="${{ matrix.DISTRO }}"
176-
if [[ "$distro" = "amazonlinux-2" ]]; then
177-
# workaround for pytest substring matching
178-
distro="amazonlinux-2 and not amazonlinux-2023"
179-
fi
180168
testcase="${{ matrix.TESTCASE }} or uninstall"
181169
python3 -u -m pytest -s --verbose -k "$distro and ${{ matrix.ARCH }} and ($testcase)" \
182170
--last-failed \

.github/workflows/installer-script-test.yml

+2-15
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,14 @@ jobs:
3838
distro=$(for d in $dockerfiles; do echo -n "\"$d\","; done)
3939
arch='"amd64","arm64"'
4040
instrumentation='"none","preload","systemd"'
41-
# amazonlinux-2 requires cgroup v1, only available on version 20.04 that doesn't have an arm runner
42-
exclude='{"DISTRO": "amazonlinux-2", "ARCH": "arm64"}'
43-
matrix="{\"DISTRO\": [${distro%,}], \"ARCH\": [${arch}], \"INSTRUMENTATION\": [${instrumentation}], \"exclude\": [${exclude}]}"
41+
matrix="{\"DISTRO\": [${distro%,}], \"ARCH\": [${arch}], \"INSTRUMENTATION\": [${instrumentation}]}"
4442
echo "$matrix" | jq
4543
echo "matrix=${matrix}" >> $GITHUB_OUTPUT
4644
outputs:
4745
matrix: ${{ steps.get-matrix.outputs.matrix }}
4846

4947
linux-installer-script-test:
50-
# Amazon Linux 2 uses cgroup v1
51-
# Ubuntu 24.04 uses cgroup v2
52-
# Fallback to Ubuntu 20.04 when appropriate
53-
runs-on: ubuntu-${{ matrix.DISTRO != 'amazonlinux-2' && '24.04' || '20.04' }}${{ matrix.ARCH == 'arm64' && '-arm' || '' }}
48+
runs-on: ubuntu-24.04${{ matrix.ARCH == 'arm64' && '-arm' || '' }}
5449
timeout-minutes: 90
5550
needs: installer-test-matrix
5651
strategy:
@@ -86,10 +81,6 @@ jobs:
8681
continue-on-error: true
8782
run: |
8883
distro="${{ matrix.DISTRO }}"
89-
if [[ "$distro" = "amazonlinux-2" ]]; then
90-
# workaround for pytest substring matching
91-
distro="amazonlinux-2 and not amazonlinux-2023"
92-
fi
9384
if [[ "${{ matrix.INSTRUMENTATION }}" = "none" ]]; then
9485
tests="$distro and ${{ matrix.ARCH }} and not instrumentation"
9586
else
@@ -103,10 +94,6 @@ jobs:
10394
if: ${{ steps.pytest.outcome == 'failure' }}
10495
run: |
10596
distro="${{ matrix.DISTRO }}"
106-
if [[ "$distro" = "amazonlinux-2" ]]; then
107-
# workaround for pytest substring matching
108-
distro="amazonlinux-2 and not amazonlinux-2023"
109-
fi
11097
if [[ "${{ matrix.INSTRUMENTATION }}" = "none" ]]; then
11198
tests="$distro and ${{ matrix.ARCH }} and not instrumentation"
11299
else

packaging/tests/images/rpm/Dockerfile.amazonlinux-2

-20
This file was deleted.

packaging/tests/instrumentation/images/rpm/Dockerfile.amazonlinux-2

-39
This file was deleted.

0 commit comments

Comments
 (0)