Skip to content

Commit b384cb7

Browse files
authored
[chore] Remove impi tool (#6190)
1 parent 20deed6 commit b384cb7

File tree

6 files changed

+3
-18
lines changed

6 files changed

+3
-18
lines changed

Makefile

+1-2
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ all-modules:
6969
@echo $(ALL_MODS) | tr ' ' '\n' | sort
7070

7171
.PHONY: all
72-
all: checklicense impi lint misspell test otelcol
72+
all: checklicense lint misspell test otelcol
7373

7474
.PHONY: for-all
7575
for-all:
@@ -232,7 +232,6 @@ install-tools:
232232
cd ./internal/tools && go install github.com/google/addlicense
233233
cd ./internal/tools && go install github.com/jstemmer/go-junit-report
234234
cd ./internal/tools && go install go.opentelemetry.io/collector/cmd/mdatagen
235-
cd ./internal/tools && go install github.com/pavius/impi/cmd/impi
236235
cd ./internal/tools && go install github.com/tcnksm/ghr
237236
cd ./internal/tools && go install golang.org/x/tools/cmd/goimports
238237
cd ./internal/tools && go install golang.org/x/tools/go/analysis/passes/fieldalignment/cmd/fieldalignment

Makefile.Common

+2-7
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ MDLINKCHECK=markdown-link-check
3838
MISSPELL=misspell -error
3939
MISSPELL_CORRECTION=misspell -w
4040
LINT=golangci-lint
41-
IMPI=impi
4241
# BUILD_TYPE should be one of (dev, release).
4342
BUILD_TYPE?=release
4443

@@ -83,7 +82,7 @@ all-pkg-dirs:
8382
.DEFAULT_GOAL := common
8483

8584
.PHONY: common
86-
common: checklicense impi lint misspell
85+
common: checklicense lint misspell
8786

8887
.PHONY: test
8988
test:
@@ -138,7 +137,7 @@ fmt: addlicense misspell-correction
138137
fieldalignment -fix ./... || true
139138

140139
.PHONY: lint
141-
lint: checklicense misspell impi
140+
lint: checklicense misspell
142141
$(LINT) run --allow-parallel-runners -j$(NUM_CORES)
143142

144143
.PHONY: tidy
@@ -155,10 +154,6 @@ misspell:
155154
misspell-correction:
156155
$(MISSPELL_CORRECTION) $(ALL_SRC_AND_DOC)
157156

158-
.PHONY: impi
159-
impi:
160-
@$(IMPI) --local github.com/signalfx/splunk-otel-collector --skip internal/signalfx-agent --scheme stdThirdPartyLocal --ignore-generated=true ./...
161-
162157
.PHONY: moddownload
163158
moddownload:
164159
$(GOCMD) mod download

internal/signalfx-agent/Makefile

-3
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,6 @@ check: lint vet test
7777
.PHONY: checklicense
7878
checklicense: checklicense-noop
7979

80-
.PHONY: impi
81-
impi: impi-noop
82-
8380
.PHONY: misspell
8481
misspell: misspell-noop
8582

internal/tools/go.mod

-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ require (
77
github.com/golangci/golangci-lint v1.64.8
88
github.com/google/addlicense v1.1.1
99
github.com/jstemmer/go-junit-report v1.0.0
10-
github.com/pavius/impi v0.0.3
1110
github.com/tcnksm/ghr v0.16.2
1211
go.opentelemetry.io/collector/cmd/mdatagen v0.125.0
1312
golang.org/x/tools v0.32.0
@@ -107,7 +106,6 @@ require (
107106
github.com/julz/importas v0.2.0 // indirect
108107
github.com/karamaru-alpha/copyloopvar v1.2.1 // indirect
109108
github.com/kisielk/errcheck v1.9.0 // indirect
110-
github.com/kisielk/gotool v1.0.0 // indirect
111109
github.com/kkHAIKE/contextcheck v1.1.6 // indirect
112110
github.com/knadh/koanf v1.5.0 // indirect
113111
github.com/knadh/koanf/v2 v2.2.0 // indirect

internal/tools/go.sum

-3
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,6 @@ github.com/karamaru-alpha/copyloopvar v1.2.1/go.mod h1:nFmMlFNlClC2BPvNaHMdkirmT
359359
github.com/kisielk/errcheck v1.5.0/go.mod h1:pFxgyoBC7bSaBwPgfKdkLd5X25qrDl4LWUI2bnpBCr8=
360360
github.com/kisielk/errcheck v1.9.0 h1:9xt1zI9EBfcYBvdU1nVrzMzzUPUtPKs9bVSIM3TAb3M=
361361
github.com/kisielk/errcheck v1.9.0/go.mod h1:kQxWMMVZgIkDq7U8xtG/n2juOjbLgZtedi0D+/VL/i8=
362-
github.com/kisielk/gotool v1.0.0 h1:AV2c/EiW3KqPNT9ZKl07ehoAGi4C5/01Cfbblndcapg=
363362
github.com/kisielk/gotool v1.0.0/go.mod h1:XhKaO+MFFWcvkIS/tQcRk01m1F5IRFswLeQ+oQHNcck=
364363
github.com/kkHAIKE/contextcheck v1.1.6 h1:7HIyRcnyzxL9Lz06NGhiKvenXq7Zw6Q0UQu/ttjfJCE=
365364
github.com/kkHAIKE/contextcheck v1.1.6/go.mod h1:3dDbMRNBFaq8HFXWC1JyvDSPm43CmE6IuHam8Wr0rkg=
@@ -488,8 +487,6 @@ github.com/otiai10/mint v1.3.0/go.mod h1:F5AjcsTsWUqX+Na9fpHb52P8pcRX2CI6A3ctIT9
488487
github.com/otiai10/mint v1.3.1/go.mod h1:/yxELlJQ0ufhjUwhshSj+wFjZ78CnZ48/1wtmBH1OTc=
489488
github.com/pascaldekloe/goe v0.0.0-20180627143212-57f6aae5913c/go.mod h1:lzWF7FIEvWOWxwDKqyGYQf6ZUaNfKdP144TG7ZOy1lc=
490489
github.com/pascaldekloe/goe v0.1.0/go.mod h1:lzWF7FIEvWOWxwDKqyGYQf6ZUaNfKdP144TG7ZOy1lc=
491-
github.com/pavius/impi v0.0.3 h1:DND6MzU+BLABhOZXbELR3FU8b+zDgcq4dOCNLhiTYuI=
492-
github.com/pavius/impi v0.0.3/go.mod h1:x/hU0bfdWIhuOT1SKwiJg++yvkk6EuOtJk8WtDZqgr8=
493490
github.com/pelletier/go-toml v1.7.0/go.mod h1:vwGMzjaWMwyfHwgIBhI2YUM4fB6nL6lVAvS1LBMMhTE=
494491
github.com/pelletier/go-toml v1.9.5 h1:4yBQzkHv+7BHq2PQUZF3Mx0IYxG7LsP222s7Agd3ve8=
495492
github.com/pelletier/go-toml v1.9.5/go.mod h1:u1nR/EPcESfeI/szUZKdtJ0xRNbUoANCkoOuaOx1Y+c=

internal/tools/tools.go

-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323
_ "github.com/golangci/golangci-lint/cmd/golangci-lint"
2424
_ "github.com/google/addlicense"
2525
_ "github.com/jstemmer/go-junit-report"
26-
_ "github.com/pavius/impi/cmd/impi"
2726
_ "github.com/tcnksm/ghr"
2827
_ "go.opentelemetry.io/collector/cmd/mdatagen"
2928
_ "golang.org/x/tools/cmd/goimports"

0 commit comments

Comments
 (0)