Skip to content

Docker overhaul needed #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdmintz opened this issue Apr 14, 2024 · 2 comments · Fixed by #2693
Closed

Docker overhaul needed #2692

mdmintz opened this issue Apr 14, 2024 · 2 comments · Fixed by #2693
Assignees
Labels
documentation enhancement Making things better

Comments

@mdmintz
Copy link
Member

mdmintz commented Apr 14, 2024

Docker overhaul needed

The current Dockerfile no longer works on various environments. Needs an update.

The Docker ReadMe.md also needs an update.

(Note: Using SeleniumBase with Docker is optional.)

@mdmintz mdmintz added enhancement Making things better documentation labels Apr 14, 2024
@mdmintz mdmintz self-assigned this Apr 14, 2024
@mdmintz
Copy link
Member Author

mdmintz commented Apr 14, 2024

Excellent progress has been made:

> docker run seleniumbase ./run_docker_test_in_chrome.sh

***** SeleniumBase Docker Machine *****
Running example SeleniumBase test from Docker with headless Chrome...
============================= test session starts ==============================
platform linux -- Python 3.10.12, pytest-8.1.1, pluggy-1.4.0
rootdir: /SeleniumBase/examples
configfile: pytest.ini
plugins: seleniumbase-4.25.4, cov-5.0.0, html-2.0.1, metadata-3.1.1, xdist-3.5.0, ordering-0.6, rerunfailures-14.0
collected 1 item

my_first_test.py .

============================== 1 passed in 5.65s ===============================

Updates will be ready in the next release.

@mdmintz
Copy link
Member Author

mdmintz commented Apr 14, 2024

This was resolved in 4.25.4 - https://github.com/seleniumbase/SeleniumBase/releases/tag/v4.25.4
Updated Dockerfile: SeleniumBase/Dockerfile
Updated ReadMe.md: Docker - ReadMe.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement Making things better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant