Skip to content

Does Scala3doc really need to depend on flexmark-all? #10903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smarter opened this issue Dec 23, 2020 · 1 comment · Fixed by #10935
Closed

Does Scala3doc really need to depend on flexmark-all? #10903

smarter opened this issue Dec 23, 2020 · 1 comment · Fixed by #10935
Assignees
@abgruszecki
Labels
area:doctool itype:bug
Milestone
3.0.0-RC1

Comments

@smarter
Copy link
Member

smarter commented Dec 23, 2020

flexmark-all has a lot of dependencies, for dottydoc we previously stopped using flexmark-all because it made our tarballs huge for no reason (921f25a), but I see that scala3doc depends on it again: https://github.com/lampepfl/dotty/blob/8acc1cbfe41dd4f39287e02cf94b928fb9361187/project/Build.scala#L1552, is this actually needed?
@smarter smarter added this to the 3.0.0-RC1 milestone Dec 23, 2020
@abgruszecki
Copy link
Contributor

IIRC flexmark-all includes all possible extensions, and we don't need them all. Should be easily fixable.

@abgruszecki abgruszecki mentioned this issue Dec 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abgruszecki abgruszecki

Labels
area:doctool itype:bug
Projects
None yet
Milestone
3.0.0-RC1
Development

Successfully merging a pull request may close this issue.

Cleanup Scala3doc flexmark dependencies dotty-staging/dotty
2 participants
@smarter @abgruszecki