Skip to content

FutureConverters toJava and toScala should be asJava and asScala if they only wrap #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SethTisue opened this issue Jul 24, 2018 · 4 comments
Closed

FutureConverters toJava and toScala should be asJava and asScala if they only wrap #116

SethTisue opened this issue Jul 24, 2018 · 4 comments
Assignees
@lrytz

Comments

@SethTisue
Copy link
Member

SethTisue commented Jul 24, 2018 •
edited
Loading

we normally use as for wrappers and to for things that convert by copying

(FutureConverters and perhaps elsewhere, audit needed)
@SethTisue
Copy link
Member Author

volunteer to add the new names and deprecate the old names?

@lrytz
Copy link
Member

lrytz commented May 16, 2019

Argh, missed this while migrating the converters to 2.13 std lib. I'll fix it in RC3 if there's one.

@dwijnand dwijnand mentioned this issue Jul 2, 2019
Merged
@SethTisue
Copy link
Member Author

@lrytz did this end up being addressed?

@lrytz
Copy link
Member

lrytz commented Jul 19, 2019

From @NthPortal with ❤️ scala/scala#8094

@lrytz lrytz closed this as completed Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrytz lrytz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lrytz @SethTisue