Skip to content

Commit e53b5b6

Browse files
nicolasstuckinicolasstucki
committed
Add scalastyle checks
1 parent bbefa53 commit e53b5b6

File tree

3 files changed

+84
-0
lines changed

3 files changed

+84
-0
lines changed

‎.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ install:
77
- sbt ++2.10.6 ir/publishLocal tools/publishLocal jsEnvs/publishLocal testAdapter/publishLocal sbtPlugin/publishLocal
88
- cd ..
99
script:
10+
- sbt ++$TRAVIS_SCALA_VERSION root/scalastyle testSuiteJVM/scalastyle testSuiteJVM/test:scalastyle testSuite/scalastyle testSuite/test:scalastyle
1011
- sbt ++$TRAVIS_SCALA_VERSION testSuiteJVM/test
1112
- sbt ++$TRAVIS_SCALA_VERSION testSuite/test
1213
- sbt ++$TRAVIS_SCALA_VERSION 'set scalaJSUseRhino in Global := false' testSuite/test

‎project/build.sbt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
11
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.6-SNAPSHOT")
2+
3+
addSbtPlugin("org.scalastyle" % "scalastyle-sbt-plugin" % "0.8.0")

‎scalastyle-config.xml

Lines changed: 81 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
1+
<scalastyle>
2+
<name>Scalastyle configuration for Scala.js</name>
3+
4+
<check level="error" enabled="true" class="org.scalastyle.file.FileTabChecker"/>
5+
<check level="error" enabled="true" class="org.scalastyle.file.WhitespaceEndOfLineChecker"/>
6+
<check level="error" enabled="true" class="org.scalastyle.file.NewLineAtEofChecker"/>
7+
8+
<!--Indentation checker, whilst useful gives false positives on the file headers, so disabled for now-->
9+
<check level="error" enabled="false" class="org.scalastyle.file.IndentationChecker"/>
10+
11+
<!--
12+
Enforce the hard limit on line length, which is 120 characters.
13+
Most of the time the soft limit of 80 characters should be observed, but
14+
we can hardly tell an automated style checker about a soft limit.
15+
-->
16+
<check level="error" enabled="true" class="org.scalastyle.file.FileLineLengthChecker">
17+
<parameters>
18+
<parameter name="maxLineLength"><![CDATA[120]]></parameter>
19+
</parameters>
20+
</check>
21+
22+
<check level="error" enabled="true" class="org.scalastyle.scalariform.RedundantIfChecker"/>
23+
<check level="error" enabled="true" class="org.scalastyle.scalariform.SimplifyBooleanExpressionChecker"/>
24+
25+
<check level="error" enabled="true" class="org.scalastyle.scalariform.UppercaseLChecker"/>
26+
27+
<check level="error" enabled="true" class="org.scalastyle.scalariform.ProcedureDeclarationChecker"/>
28+
29+
<check level="error" enabled="true" class="org.scalastyle.scalariform.ClassNamesChecker">
30+
<parameters>
31+
<parameter name="regex"><![CDATA[^[A-Z][A-Za-z0-9]*$]]></parameter>
32+
</parameters>
33+
</check>
34+
<check level="error" enabled="true" class="org.scalastyle.scalariform.ObjectNamesChecker">
35+
<parameters>
36+
<parameter name="regex"><![CDATA[^[A-Z][A-Za-z0-9]*$]]></parameter>
37+
</parameters>
38+
</check>
39+
<check level="error" enabled="true" class="org.scalastyle.scalariform.PackageObjectNamesChecker">
40+
<parameters>
41+
<parameter name="regex"><![CDATA[^[a-z][A-Za-z]*$]]></parameter>
42+
</parameters>
43+
</check>
44+
45+
<check level="error" enabled="true" class="org.scalastyle.scalariform.EqualsHashCodeChecker"/>
46+
<check level="error" enabled="true" class="org.scalastyle.scalariform.CovariantEqualsChecker"/>
47+
48+
<check level="error" enabled="true" class="org.scalastyle.scalariform.IllegalImportsChecker">
49+
<parameters>
50+
<parameter name="illegalImports"><![CDATA[sun._,java.awt._]]></parameter>
51+
</parameters>
52+
</check>
53+
54+
<check level="error" enabled="true" class="org.scalastyle.scalariform.ReturnChecker"/>
55+
56+
<check level="error" enabled="true" class="org.scalastyle.scalariform.EmptyClassChecker"/>
57+
58+
<!-- Currently too strict, see https://github.com/scalastyle/scalastyle/issues/142 -->
59+
<check level="error" enabled="false" class="org.scalastyle.scalariform.ForBraceChecker"/>
60+
61+
<check level="error" enabled="true" class="org.scalastyle.scalariform.PublicMethodsHaveTypeChecker"/>
62+
63+
<check level="error" enabled="true" class="org.scalastyle.scalariform.NoWhitespaceBeforeLeftBracketChecker"/>
64+
<check level="error" enabled="true" class="org.scalastyle.scalariform.NoWhitespaceAfterLeftBracketChecker"/>
65+
66+
<check level="error" enabled="true" class="org.scalastyle.scalariform.DisallowSpaceBeforeTokenChecker">
67+
<parameters>
68+
<parameter name="tokens">COLON, COMMA, RPAREN</parameter>
69+
</parameters>
70+
</check>
71+
<check level="error" enabled="true" class="org.scalastyle.scalariform.DisallowSpaceAfterTokenChecker">
72+
<parameters>
73+
<parameter name="tokens">LPAREN</parameter>
74+
</parameters>
75+
</check>
76+
<check level="error" enabled="true" class="org.scalastyle.scalariform.EnsureSingleSpaceAfterTokenChecker">
77+
<parameters>
78+
<parameter name="tokens">IF, FOR, WHILE, DO, TRY</parameter>
79+
</parameters>
80+
</check>
81+
</scalastyle>

0 commit comments

Comments
 (0)