Skip to content

Support HTMLDialogElement #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
halfmatthalfcat opened this issue Apr 22, 2016 · 3 comments · Fixed by #708
Closed

Support HTMLDialogElement #223

halfmatthalfcat opened this issue Apr 22, 2016 · 3 comments · Fixed by #708
Labels
good first issue We'd love a PR! help wanted

Comments

@halfmatthalfcat
Copy link

Support for the Dialog element is slowly gaining support among browsers and is already implemented in Chrome/Opera. Add a scalajs interface per the HTMLDialogElement spec: https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement
@armanbilge
Copy link
Member

5 years later yet still less than 75% at caniuse :(

@Lasering
Copy link
Contributor

Lasering commented Jun 28, 2022 •
edited
Loading

Now is at 87.75% (with IE still being included).

For those interested in using dialog:

document.getElementById("myDialog").asInstanceOf[js.Dynamic].showModal()

@armanbilge armanbilge reopened this Jun 28, 2022
@armanbilge
Copy link
Member

Will happily take a PR for this. We changed our policy to accept any standardized APIs regardless of adoption.

This was referenced Jun 28, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue We'd love a PR! help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create HTMLDialogElement Lasering/scala-js-dom
3 participants
@halfmatthalfcat @armanbilge @Lasering