new Audio() constructor

[faveoled]

https://developer.mozilla.org/en-US/docs/Web/API/HTMLAudioElement/Audio

new Audio()
new Audio(url)

How do I translate this to Scala.js DOM?

[armanbilge]

Hmm, I'm confused how this works since the name used by the constructor is different from the class. Good question! @sjrd can you enlighten us please 😅 🙏

[faveoled]

Found a possible implementation here
https://github.com/tmtsoftware/tmt-typed/blob/fdf18ba48c89466c7197e40f6d5c9b49b30e505f/modules/std/src/main/scala/typings/std/Audio.scala

[armanbilge]

Tried this but it wasn't compiling so I gave up

What was the compile error?

[armanbilge]

Actually feel free to open a PR with that, so we can help more easily :)

[faveoled]

Tried this but it wasn't compiling so I gave up

What was the compile error?

class Audio needs to be abstract, since var srcObject: 
  scala.scalajs.js.UndefOr[org.scalajs.dom.MediaStream | 
    org.scalajs.dom.MediaSource
   | org.scalajs.dom.Blob] in class HTMLMediaElement in package org.scalajs.dom is not defined 
(Note that variables need to be initialized to be defined)

[armanbilge]

Woops, it looks like we forgot to write = js.native here:

scala-js-dom/dom/src/main/scala/org/scalajs/dom/HTMLMediaElement.scala

Lines 129 to 130 in 260fdf0

	/** Sets or returns the object which serves as the source of the media associated with the HTMLMediaElement. */
	var srcObject: js.UndefOr[MediaStream | MediaSource | Blob]

[faveoled]

My solution so far is this:

import org.scalajs.dom.HTMLAudioElement
import scala.scalajs.js

def audio(url: String): HTMLAudioElement = {
  js.Dynamic
    .newInstance(js.Dynamic.global.Audio)(url)
    .asInstanceOf[HTMLAudioElement]
}

def audio(): HTMLAudioElement = {
  js.Dynamic
    .newInstance(js.Dynamic.global.Audio)()
    .asInstanceOf[HTMLAudioElement]
}

[zetashift]

I think you'll want something similiar to the Image PR, and feel free to open up a Pull Request! The steps to open one up are outlined here: https://github.com/scala-js/scala-js-dom/blob/main/CONTRIBUTING.md

class Image(width: Int, height: Int) extends HTMLImageElement {
  def this(width: Int) = this(width, 0)
  def this() = this(0, 0)
}

So maybe something like this( I am unsure how scala-js-dom deals with optional constructor values)

class Audio(url: js.UndefOr[String] = js.native) extends HTMLAudioElement {}

@armanbilge am I close with this?

[armanbilge]

That seems fine, you can also do two constructors instead of an UndefOr and default parameter, that tends to work better for type inference.

[zetashift]

class Audio(url: String) extends HTMLAudioElement {
  def this(url: String) = js.native
  def this() = js.native
}

I was unsure what the body of the constructors should be.

[armanbilge]

Maybe like this. Implementations don't matter (they are discarded), since its just a facade.

class Audio extends HTMLAudioElement {
  def this(url: String) = this()
}

[zetashift]

Right I forgot that!

so @faveoled if you have the time you could do the following

• Create a new Audio.scala in ./dom/src/main/scala/org/scalajs/dom/
• The code for your Audio constructur will look like this:

class Audio extends HTMLAudioElement {
  def this(url: String) = this()
}

• run sbt prePR (this will take a while)
• commit the changes(the ones in api-reports folders as well)

If you need any help let me know!