From cca0f6d7d8063010f5fe2bf3fd712f4a9f41f7b9 Mon Sep 17 00:00:00 2001 From: Agam Brahma Date: Tue, 25 Feb 2020 22:42:48 -0800 Subject: [PATCH] Suggest using `toList` instead of `to(List)` As an example, on OSX with Scala version `2.13.1`, I see ``` scala> def average(x: Int, xs: Int*): Double = | (x :: xs.to(List)).sum.toDouble / (xs.size + 1) :13: error: type mismatch; found : scala.collection.immutable.List.type required: scala.collection.generic.CanBuildFrom[Nothing,Int,?] (x :: xs.to(List)).sum.toDouble / (xs.size + 1) ^ ``` --- .../scala/scalatutorial/sections/SyntacticConveniences.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/scala/scalatutorial/sections/SyntacticConveniences.scala b/src/main/scala/scalatutorial/sections/SyntacticConveniences.scala index 2a0418e1..144bec9b 100644 --- a/src/main/scala/scalatutorial/sections/SyntacticConveniences.scala +++ b/src/main/scala/scalatutorial/sections/SyntacticConveniences.scala @@ -342,7 +342,7 @@ object SyntacticConveniences extends ScalaTutorialSection { */ def repeatedParameters(res0: Double): Unit = { def average(x: Int, xs: Int*): Double = - (x :: xs.to(List)).sum.toDouble / (xs.size + 1) + (x :: xs.toList).sum.toDouble / (xs.size + 1) average(1) shouldBe 1.0 average(1, 2) shouldBe 1.5