aml: initial support for DefObjectType and test it

This doesn't do everything yet (particularly it doesn't handle object
references), but it should get most of the way there.

Author: IsaacWoods

aml/src/expression.rs

@@ -1,5 +1,6 @@
 use crate::{
-    name_object::{name_string, super_name, target},
+    misc::debug_obj,
+    name_object::{name_string, simple_name, super_name, target},
     opcode::{self, opcode},
     parser::{choice, comment_scope, n_of, take, take_to_end_of_pkglength, try_with_context, Parser, Propagate},
     pkg_length::pkg_length,
@@ -50,6 +51,7 @@ where
             def_l_not_equal(),
             def_l_or(),
             def_mid(),
+            def_object_type(),
             def_package(),
             def_shift_left(),
             def_shift_right(),
@@ -501,6 +503,77 @@ where
         .map(|((), result)| Ok(result))
 }
 
+pub fn def_object_type<'a, 'c>() -> impl Parser<'a, 'c, AmlValue>
+where
+    'c: 'a,
+{
+    /*
+     * DefObjectType := 0x8e <SimpleName | DebugObj | DefRefOf | DefDerefOf | DefIndex>
+     *
+     * Returns an integer representing the type of an AML object. If executed on an object that is a reference to a
+     * value (e.g. produced by `Alias`, `RefOf`, or `Index`), the type of the base object is returned. For typeless
+     * objects, such as scopes, a type of `0 - Uninitialized` is returned.
+     *
+     *    0 = Uninitialized
+     *    1 = Integer
+     *    2 = String
+     *    3 = Buffer
+     *    4 = Package
+     *    5 = Field Unit
+     *    6 = Device
+     *    7 = Event
+     *    8 = Method
+     *    9 = Mutex
+     *    10 = Operation Region
+     *    11 = Power Resource
+     *    12 = Processor
+     *    13 = Thermal Zone
+     *    14 = Buffer Field
+     *    15 = Reserved
+     *    16 = Debug Object
+     *    >16 = *Reserved*
+     */
+    // TODO: this doesn't correctly handle taking the type of a namespace node (e.g. `\_SB`), but I'm not sure any
+    // other implementations do either?
+    opcode(opcode::DEF_OBJECT_TYPE_OP)
+        .then(comment_scope(
+            DebugVerbosity::AllScopes,
+            "DefObjectType",
+            choice!(
+                simple_name().map_with_context(|target, context| {
+                    let value = try_with_context!(context, context.read_target(&target));
+                    let typ = match value.type_of() {
+                        AmlType::Uninitialized => 0,
+                        AmlType::Integer => 1,
+                        AmlType::String => 2,
+                        AmlType::Buffer => 3,
+                        AmlType::RawDataBuffer => 3, // TODO: not sure if this is correct
+                        AmlType::Package => 4,
+                        AmlType::FieldUnit => 5,
+                        AmlType::Device => 6,
+                        AmlType::Event => 7,
+                        AmlType::Method => 8,
+                        AmlType::Mutex => 9,
+                        AmlType::OpRegion => 10,
+                        AmlType::PowerResource => 11,
+                        AmlType::Processor => 12,
+                        AmlType::ThermalZone => 13,
+                        AmlType::BufferField => 14,
+                        AmlType::DebugObject => 16,
+
+                        // TODO: what to do with this?
+                        AmlType::DdbHandle => 0,
+                        AmlType::ObjReference => todo!(),
+                    };
+
+                    (Ok(AmlValue::Integer(typ)), context)
+                }),
+                debug_obj().map(|()| Ok(AmlValue::Integer(16)))
+            ),
+        ))
+        .map(|((), result)| Ok(result))
+}
+
 pub fn def_package<'a, 'c>() -> impl Parser<'a, 'c, AmlValue>
 where
     'c: 'a,

aml/src/opcode.rs

@@ -66,6 +66,7 @@ pub const DEF_SHIFT_LEFT: u8 = 0x79;
 pub const DEF_SHIFT_RIGHT: u8 = 0x7a;
 pub const DEF_AND_OP: u8 = 0x7b;
 pub const DEF_CONCAT_RES_OP: u8 = 0x84;
+pub const DEF_OBJECT_TYPE_OP: u8 = 0x8e;
 pub const DEF_L_OR_OP: u8 = 0x91;
 pub const DEF_L_NOT_OP: u8 = 0x92;
 pub const DEF_L_EQUAL_OP: u8 = 0x93;

tests/object_type.asl

@@ -0,0 +1,19 @@
+DefinitionBlock("object_type.aml", "DSDT", 1, "RSACPI", "OBJTYP", 1) {
+	Name(INT, 723)
+	Name(STR, "Hello, World!")
+	Name(BUFF, Buffer { 7, 2, 3, 5, 92, 6 })
+	// TODO: more types
+
+	Device(TYPS) {
+		// This is just so it compiles
+		Name (_HID, EisaId ("PNP0A03"))
+
+		Name(INT, 0)	// Should be `1`
+		Name(STR, 0)	// Should be `2`
+		Name(BUFF, 0)	// Should be `3`
+
+		INT = ObjectType(\INT)
+		STR = ObjectType(\STR)
+		BUFF = ObjectType(\BUFF)
+	}
+}