Skip to content

fail!() requires formatting in libcore #16700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bluss opened this issue Aug 23, 2014 · 1 comment
Closed

fail!() requires formatting in libcore #16700

bluss opened this issue Aug 23, 2014 · 1 comment
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@bluss
Copy link
Member

bluss commented Aug 23, 2014

libcore's failure hooks require its users to use formatting. libcore users like all the instances of fail!() or assert!() with a simple message would generate less code if there was a format-less code path.

This already exists in the libstd fail!().
@bluss bluss mentioned this issue Aug 24, 2014
Closed
@huonw huonw added the I-slow label Aug 30, 2014
@bluss
Copy link
Member Author

bluss commented May 25, 2015

This is fixed, because panic!("string literal") does not insert much more than a function call to a #[cold] function now.

@bluss bluss closed this as completed May 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huonw @bluss