Skip to content

custom tag discriminants not considered in the shape code #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nikomatsakis opened this issue Jan 12, 2012 · 1 comment
Closed

custom tag discriminants not considered in the shape code #1499

nikomatsakis opened this issue Jan 12, 2012 · 1 comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows

Comments

@nikomatsakis
Copy link
Contributor

I just realized that the shape code knows nothing about custom tag discriminants. I would prefer to fix this by fixing #1498.
@nikomatsakis
Copy link
Contributor Author

I was wrong. As we only allow custom discriminants in "C-like" tags, which are represented as integers, the shape code works out. I will nonetheless add a test or two to make sure this continues to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikomatsakis