Save more items into incremental cache

Without it compiler skips codengen stage and generating those
intermediate byproducts and then fails when it comes to copying them to
stable locations:

export RUSTFLAGS=--emit=asm
cargo new --lib foo && cd foo
cargo build
touch src/lib.rs
cargo build

Author: pacak

compiler/rustc_codegen_cranelift/src/driver/aot.rs

@@ -341,6 +341,8 @@ fn emit_cgu(
             object: Some(global_asm_object_file),
             dwarf_object: None,
             bytecode: None,
+            asm: None,
+            llvm: None,
         }),
         existing_work_product: None,
     })
@@ -378,7 +380,15 @@ fn emit_module(
 
     prof.artifact_size("object_file", &*name, file.metadata().unwrap().len());
 
-    Ok(CompiledModule { name, kind, object: Some(tmp_file), dwarf_object: None, bytecode: None })
+    Ok(CompiledModule {
+        name,
+        kind,
+        object: Some(tmp_file),
+        dwarf_object: None,
+        bytecode: None,
+        asm: None,
+        llvm: None,
+    })
 }
 
 fn reuse_workproduct_for_cgu(
@@ -426,13 +436,17 @@ fn reuse_workproduct_for_cgu(
             object: Some(obj_out_regular),
             dwarf_object: None,
             bytecode: None,
+            asm: None,
+            llvm: None,
         },
         module_global_asm: has_global_asm.then(|| CompiledModule {
             name: cgu.name().to_string(),
             kind: ModuleKind::Regular,
             object: Some(obj_out_global_asm),
             dwarf_object: None,
             bytecode: None,
+            asm: None,
+            llvm: None,
         }),
         existing_work_product: Some((cgu.work_product_id(), work_product)),
     })
@@ -678,6 +692,8 @@ pub(crate) fn run_aot(
             object: Some(tmp_file),
             dwarf_object: None,
             bytecode: None,
+            asm: None,
+            llvm: None,
         })
     } else {
         None

compiler/rustc_codegen_gcc/src/back/write.rs

@@ -158,6 +158,8 @@ pub(crate) unsafe fn codegen(
         config.emit_obj != EmitObj::None,
         cgcx.target_can_use_split_dwarf && cgcx.split_debuginfo == SplitDebuginfo::Unpacked,
         config.emit_bc,
+        config.emit_asm,
+        config.emit_ir,
         &cgcx.output_filenames,
     ))
 }

compiler/rustc_codegen_llvm/src/back/write.rs

@@ -880,6 +880,8 @@ pub(crate) unsafe fn codegen(
         config.emit_obj != EmitObj::None,
         dwarf_object_emitted,
         config.emit_bc,
+        config.emit_asm,
+        config.emit_ir,
         &cgcx.output_filenames,
     ))
 }

compiler/rustc_codegen_ssa/src/back/write.rs

@@ -533,7 +533,15 @@ fn copy_all_cgu_workproducts_to_incr_comp_cache_dir(
         if let Some(dwarf_object_file_path) = &module.dwarf_object {
             files.push(("dwo", dwarf_object_file_path.as_path()));
         }
-
+        if let Some(path) = &module.asm {
+            files.push(("s", path.as_path()));
+        }
+        if let Some(path) = &module.llvm {
+            files.push(("ll", path.as_path()));
+        }
+        if let Some(path) = &module.bytecode {
+            files.push(("bc", path.as_path()));
+        }
         if let Some((id, product)) =
             copy_cgu_workproduct_to_incr_comp_cache_dir(sess, &module.name, files.as_slice())
         {
@@ -937,12 +945,47 @@ fn execute_copy_from_cache_work_item<B: ExtraBackendMethods>(
             load_from_incr_comp_dir(dwarf_obj_out, saved_dwarf_object_file)
         });
 
+    let asm = module_config
+        .emit_asm
+        .then(|| {
+            module.source.saved_files.get("s").as_ref().and_then(|saved_asm_file| {
+                let output_path =
+                    cgcx.output_filenames.temp_path(OutputType::Assembly, Some(&module.name));
+                load_from_incr_comp_dir(output_path, &saved_asm_file)
+            })
+        })
+        .flatten();
+
+    let llvm = module_config
+        .emit_ir
+        .then(|| {
+            module.source.saved_files.get("ll").as_ref().and_then(|saved_ir_file| {
+                let output_path =
+                    cgcx.output_filenames.temp_path(OutputType::LlvmAssembly, Some(&module.name));
+                load_from_incr_comp_dir(output_path, &saved_ir_file)
+            })
+        })
+        .flatten();
+
+    let bytecode = module_config
+        .emit_bc
+        .then(|| {
+            module.source.saved_files.get("bc").as_ref().and_then(|saved_bc_file| {
+                let output_path =
+                    cgcx.output_filenames.temp_path(OutputType::Bitcode, Some(&module.name));
+                load_from_incr_comp_dir(output_path, &saved_bc_file)
+            })
+        })
+        .flatten();
+
     WorkItemResult::Finished(CompiledModule {
         name: module.name,
         kind: ModuleKind::Regular,
         object,
         dwarf_object,
-        bytecode: None,
+        bytecode,
+        asm,
+        llvm,
     })
 }
 

compiler/rustc_codegen_ssa/src/base.rs

@@ -629,6 +629,8 @@ pub fn codegen_crate<B: ExtraBackendMethods>(
                 object: Some(file_name),
                 dwarf_object: None,
                 bytecode: None,
+                asm: None,
+                llvm: None,
             }
         })
     });

compiler/rustc_codegen_ssa/src/lib.rs

@@ -79,13 +79,25 @@ impl<M> ModuleCodegen<M> {
         emit_obj: bool,
         emit_dwarf_obj: bool,
         emit_bc: bool,
+        emit_asm: bool,
+        emit_ir: bool,
         outputs: &OutputFilenames,
     ) -> CompiledModule {
         let object = emit_obj.then(|| outputs.temp_path(OutputType::Object, Some(&self.name)));
         let dwarf_object = emit_dwarf_obj.then(|| outputs.temp_path_dwo(Some(&self.name)));
         let bytecode = emit_bc.then(|| outputs.temp_path(OutputType::Bitcode, Some(&self.name)));
+        let asm = emit_asm.then(|| outputs.temp_path(OutputType::Assembly, Some(&self.name)));
+        let llvm = emit_ir.then(|| outputs.temp_path(OutputType::LlvmAssembly, Some(&self.name)));
 
-        CompiledModule { name: self.name.clone(), kind: self.kind, object, dwarf_object, bytecode }
+        CompiledModule {
+            name: self.name.clone(),
+            kind: self.kind,
+            object,
+            dwarf_object,
+            bytecode,
+            asm,
+            llvm,
+        }
     }
 }
 
@@ -96,6 +108,10 @@ pub struct CompiledModule {
     pub object: Option<PathBuf>,
     pub dwarf_object: Option<PathBuf>,
     pub bytecode: Option<PathBuf>,
+
+    /// items created to satisfy --emit
+    pub asm: Option<PathBuf>, // --emit=asm
+    pub llvm: Option<PathBuf>, // --emit=llvm-ir, llvm-bc is in bytecode
 }
 
 pub struct CachedModuleCodegen {

tests/run-make/asm-incr-cache/Makefile

@@ -0,0 +1,15 @@
+include ../tools.mk
+
+# ignore-windows
+# ignore-freebsd
+# FIXME: on windows `rustc --dep-info` produces Makefile dependency with
+# windows native paths (e.g. `c:\path\to\libfoo.a`)
+# but msys make seems to fail to recognize such paths, so test fails.
+
+all:
+	cp *.rs $(TMPDIR)
+	$(RUSTC) --emit obj,asm,dep-info,link --crate-type=lib $(TMPDIR)/lib.rs -C incremental=$(TMPDIR)/inc
+	sleep 2
+	touch $(TMPDIR)/lib.rs
+	# this should compile as usual
+	$(RUSTC) --emit obj,asm,dep-info,link --crate-type=lib $(TMPDIR)/lib.rs -C incremental=$(TMPDIR)/inc

tests/run-make/asm-incr-cache/lib.rs

@@ -0,0 +1,6 @@
+#![crate_name = "foo"]
+
+#[inline(never)]
+pub fn add(a: u32, b: u32) -> u32 {
+    a + b
+}