Skip to content

Commit 787a21f

Browse files
committed
Fix some typos in SSE-AVX intrinsics.
I believe everything that doesn't take a constant integer up to SSE4.2 should now be correct (I don't have any reason to believe that those that do take constant integers are wrong; they're just more complicated and I just haven't tested them in detail).
1 parent bb6be30 commit 787a21f

File tree

4 files changed

+26
-21
lines changed

4 files changed

+26
-21
lines changed

src/etc/platform-intrinsics/x86/sse2.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
"intrinsic": "_madd_epi16",
2020
"width": [128],
2121
"llvm": "pmadd.wd",
22-
"ret": "s16",
23-
"args": ["0", "0"]
22+
"ret": "s32",
23+
"args": ["s16", "s16"]
2424
},
2525
{
2626
"intrinsic": "_max_{0.data_type}",
@@ -68,11 +68,11 @@
6868
"intrinsic": "_mul_epu32",
6969
"width": [128],
7070
"llvm": "pmulu.dq",
71-
"ret": "s64",
71+
"ret": "u64",
7272
"args": ["0dn", "0dn"]
7373
},
7474
{
75-
"intrinsic": "_mulhi_ep{0.kind}16",
75+
"intrinsic": "_mulhi_{0.data_type}",
7676
"width": [128],
7777
"llvm": "pmulh{0.kind_short}.w",
7878
"ret": "i16",

src/etc/platform-intrinsics/x86/sse41.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
{
4040
"intrinsic": "_mul_epi32",
4141
"width": [128],
42-
"llvm": "muldq",
42+
"llvm": "pmuldq",
4343
"ret": "s64",
4444
"args": ["s32", "s32"]
4545
},
@@ -58,9 +58,9 @@
5858
"args": ["u64", "u64"]
5959
},
6060
{
61-
"intrinsic": "_testncz_si128",
61+
"intrinsic": "_testnzc_si128",
6262
"width": [128],
63-
"llvm": "ptest.nzc",
63+
"llvm": "ptestnzc",
6464
"ret": "S32",
6565
"args": ["u64", "u64"]
6666
},

src/etc/platform-intrinsics/x86/ssse3.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
{
55
"intrinsic": "_abs_{0.data_type}",
66
"width": [128],
7-
"llvm": "pabs.{0.data_type_short}",
7+
"llvm": "pabs.{0.data_type_short}.128",
88
"ret": "s(8-32)",
99
"args": ["0"]
1010
},
@@ -41,7 +41,7 @@
4141
"width": [128],
4242
"llvm": "pmadd.ub.sw.128",
4343
"ret": "s16",
44-
"args": ["s8", "s8"]
44+
"args": ["u8", "s8"]
4545
},
4646
{
4747
"intrinsic": "_mulhrs_epi16",
@@ -61,7 +61,7 @@
6161
"intrinsic": "_sign_{0.data_type}",
6262
"width": [128],
6363
"llvm": "psign.{0.data_type_short}.128",
64-
"ret": "s(8-16)",
64+
"ret": "s(8-32)",
6565
"args": ["0", "0"]
6666
}
6767
]

src/librustc_platform_intrinsics/x86.rs

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ pub fn find<'tcx>(_tcx: &ty::ctxt<'tcx>, name: &str) -> Option<Intrinsic> {
8282
},
8383
"_madd_epi16" => Intrinsic {
8484
inputs: vec![v(i(16), 8), v(i(16), 8)],
85-
output: v(i(16), 8),
85+
output: v(i(32), 4),
8686
definition: Named("llvm.x86.sse2.pmadd.wd")
8787
},
8888
"_max_epi16" => Intrinsic {
@@ -126,11 +126,11 @@ pub fn find<'tcx>(_tcx: &ty::ctxt<'tcx>, name: &str) -> Option<Intrinsic> {
126126
definition: Named("llvm.x86.sse2.pmovmskb.128")
127127
},
128128
"_mul_epu32" => Intrinsic {
129-
inputs: vec![v(i(32), 4), v(i(32), 4)],
130-
output: v(i(64), 2),
129+
inputs: vec![v(u(32), 4), v(u(32), 4)],
130+
output: v(u(64), 2),
131131
definition: Named("llvm.x86.sse2.pmulu.dq")
132132
},
133-
"_mulhi_eps16" => Intrinsic {
133+
"_mulhi_epi16" => Intrinsic {
134134
inputs: vec![v(i(16), 8), v(i(16), 8)],
135135
output: v(i(16), 8),
136136
definition: Named("llvm.x86.sse2.pmulh.w")
@@ -218,17 +218,17 @@ pub fn find<'tcx>(_tcx: &ty::ctxt<'tcx>, name: &str) -> Option<Intrinsic> {
218218
"_abs_epi8" => Intrinsic {
219219
inputs: vec![v(i(8), 16)],
220220
output: v(i(8), 16),
221-
definition: Named("llvm.x86.ssse3.pabs.b")
221+
definition: Named("llvm.x86.ssse3.pabs.b.128")
222222
},
223223
"_abs_epi16" => Intrinsic {
224224
inputs: vec![v(i(16), 8)],
225225
output: v(i(16), 8),
226-
definition: Named("llvm.x86.ssse3.pabs.w")
226+
definition: Named("llvm.x86.ssse3.pabs.w.128")
227227
},
228228
"_abs_epi32" => Intrinsic {
229229
inputs: vec![v(i(32), 4)],
230230
output: v(i(32), 4),
231-
definition: Named("llvm.x86.ssse3.pabs.d")
231+
definition: Named("llvm.x86.ssse3.pabs.d.128")
232232
},
233233
"_hadd_epi16" => Intrinsic {
234234
inputs: vec![v(i(16), 8), v(i(16), 8)],
@@ -261,7 +261,7 @@ pub fn find<'tcx>(_tcx: &ty::ctxt<'tcx>, name: &str) -> Option<Intrinsic> {
261261
definition: Named("llvm.x86.ssse3.phsub.sw.128")
262262
},
263263
"_maddubs_epi16" => Intrinsic {
264-
inputs: vec![v(i(8), 16), v(i(8), 16)],
264+
inputs: vec![v(u(8), 16), v(i(8), 16)],
265265
output: v(i(16), 8),
266266
definition: Named("llvm.x86.ssse3.pmadd.ub.sw.128")
267267
},
@@ -285,6 +285,11 @@ pub fn find<'tcx>(_tcx: &ty::ctxt<'tcx>, name: &str) -> Option<Intrinsic> {
285285
output: v(i(16), 8),
286286
definition: Named("llvm.x86.ssse3.psign.w.128")
287287
},
288+
"_sign_epi32" => Intrinsic {
289+
inputs: vec![v(i(32), 4), v(i(32), 4)],
290+
output: v(i(32), 4),
291+
definition: Named("llvm.x86.ssse3.psign.d.128")
292+
},
288293
"_dp_ps" => Intrinsic {
289294
inputs: vec![v(f(32), 4), v(f(32), 4), i_(32, 8)],
290295
output: v(f(32), 4),
@@ -348,7 +353,7 @@ pub fn find<'tcx>(_tcx: &ty::ctxt<'tcx>, name: &str) -> Option<Intrinsic> {
348353
"_mul_epi32" => Intrinsic {
349354
inputs: vec![v(i(32), 4), v(i(32), 4)],
350355
output: v(i(64), 2),
351-
definition: Named("llvm.x86.sse41.muldq")
356+
definition: Named("llvm.x86.sse41.pmuldq")
352357
},
353358
"_packus_epi32" => Intrinsic {
354359
inputs: vec![v(i(32), 4), v(i(32), 4)],
@@ -360,10 +365,10 @@ pub fn find<'tcx>(_tcx: &ty::ctxt<'tcx>, name: &str) -> Option<Intrinsic> {
360365
output: i(32),
361366
definition: Named("llvm.x86.sse41.ptestc")
362367
},
363-
"_testncz_si128" => Intrinsic {
368+
"_testnzc_si128" => Intrinsic {
364369
inputs: vec![v(u(64), 2), v(u(64), 2)],
365370
output: i(32),
366-
definition: Named("llvm.x86.sse41.ptest.nzc")
371+
definition: Named("llvm.x86.sse41.ptestnzc")
367372
},
368373
"_testz_si128" => Intrinsic {
369374
inputs: vec![v(u(64), 2), v(u(64), 2)],

0 commit comments

Comments
 (0)