Only mark spans in incremental mode.

Author: cjgillot

compiler/rustc_resolve/src/def_collector.rs

@@ -129,7 +129,9 @@ impl<'a, 'b, 'tcx> DefCollector<'a, 'b, 'tcx> {
 
 impl<'a, 'b, 'tcx> mut_visit::MutVisitor for DefCollector<'a, 'b, 'tcx> {
     fn visit_span(&mut self, span: &mut Span) {
-        *span = span.with_parent(Some(self.parent_def));
+        if self.resolver.tcx.sess.opts.incremental.is_some() {
+            *span = span.with_parent(Some(self.parent_def));
+        }
     }
 
     #[tracing::instrument(level = "trace", skip(self))]

tests/ui/macros/issue-69396-const-no-type-in-macro.stderr

@@ -2,10 +2,7 @@ error[E0428]: the name `A` is defined multiple times
   --> $DIR/issue-69396-const-no-type-in-macro.rs:4:13
    |
 LL |               const A = "A".$fn();
-   |               ^^^^^^^^^^^^^^^^^^^^
-   |               |
-   |               `A` redefined here
-   |               previous definition of the value `A` here
+   |               ^^^^^^^^^^^^^^^^^^^^ `A` redefined here
 ...
 LL | / suite! {
 LL | |     len;