Pinned variables should be treated as usages, not definitions

Author: kddnewton

lib/syntax_tree/with_scope.rb

@@ -197,7 +197,13 @@ def visit_var_field(node)
       super
     end
 
-    alias visit_pinned_var_ref visit_var_field
+    # Visit for keeping track of local variable definitions
+    def visit_pinned_var_ref(node)
+      value = node.value
+      current_scope.add_local_usage(value, :variable) if value.is_a?(Ident)
+
+      super
+    end
 
     # Visits for keeping track of variable and argument usages
     def visit_var_ref(node)

test/with_scope_test.rb

@@ -109,7 +109,7 @@ def foo
       RUBY
 
       assert_equal(2, collector.variables.length)
-      assert_variable(collector, "a", definitions: [2, 4], usages: [5])
+      assert_variable(collector, "a", definitions: [2], usages: [4, 5])
       assert_variable(collector, "rest", definitions: [4])
 
       # Rest is considered a vcall by the parser instead of a var_ref