Development react.js and production react.js are identical in react-rails 1.4.0 gem

[Chehai]

In react-rails 1.3.3, production react.js is minified while development react.js is not minified.

[rmosolgo]

I thought I'd let people minify it with Sprockets / asset pipeline. Is that a bad option for your case?

[Chehai]

Well, the real problem is that after asset compilation in production react.js is still in development mode, because Rails asset pipeline does not set process.env.NODE_ENV to be production.

[rmosolgo]

Oh! I thought this was enough, but I guess it wasn't:

https://github.com/reactjs/react-rails/blob/master/react-builds/webpack.config.js#L23

I'll have to dig deeper in to figure that out

[Chehai]

Thanks for looking at it!

React-rails 1.3.3 drops a minified react.js without any process.env.NODE_ENV in code to Rails asset pipeline. 1.4.4 drops a un-minified react.js with process.env.NODE_ENV everywhere in code to the pipeline.

[rmosolgo]

🎊 #380

[rmosolgo]

Shipped in 1.4.1, thanks for the report and let me know how that one goes for you!

[Chehai]

Thanks for fixing it! 1.4.1 works well for us.