Skip to content

Revisit initialization #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
rmosolgo opened this issue Apr 28, 2015 · 2 comments
Closed
6 tasks done

Revisit initialization #252

rmosolgo opened this issue Apr 28, 2015 · 2 comments

Comments

@rmosolgo
Copy link
Member

There are a lot of issues popping up regarding how react-rails sets up & handles app initialization. I want to work out these problems.

To do

@rmosolgo
Copy link
Member Author

I have some ideas to kick things off:

  • Instead of copying files into the app directory, add different gem directories to the asset pipeline based on config.react.variant. (For example, if :development, then add /vendor/development/, whose copy of react.js is the dev build. If :production, add /vendor/production, whose react.js file is the production build. That way, no file copying on boot.)
  • Decouple the server renderer, as suggested here: Better support for Flux architecture #143 (comment)
  • Write some failing tests for the initializers, fiddle with em til they work!

@rmosolgo
Copy link
Member Author

.jsx_transform_options is a wont-fix for me, the work around is to assign JSX.transform_options directly and I think that's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant