Skip to content

Commit e33848f

Browse files
committed
update tests for react_ujs dependency
1 parent 41721c5 commit e33848f

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

test/react/server_rendering/exec_js_renderer_test.rb

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,19 @@
55
var React = {
66
createElement: function() {},
77
}
8-
var ReactDOMServer = {
9-
renderToString: function() {
10-
return 'renderToString was called'
8+
var ReactRailsUJS = {
9+
serverRender: function() {
10+
return 'serverRender was called'
1111
},
1212
}
1313
"
1414

1515
class ExecJSRendererTest < ActiveSupport::TestCase
1616
setup do
1717
react_server_source = File.read(File.expand_path("../../../../lib/assets/react-source/production/react-server.js", __FILE__))
18+
react_ujs_source = File.read(File.expand_path("../../../../lib/assets/javascripts/react_ujs.js", __FILE__))
1819
todo_component_source = File.read(File.expand_path("../../../dummy/app/assets/javascripts/components/PlainJSTodo.js", __FILE__))
19-
code = react_server_source + todo_component_source
20+
code = react_server_source + react_ujs_source + todo_component_source
2021
@renderer = React::ServerRendering::ExecJSRenderer.new(code: code)
2122
end
2223

@@ -70,6 +71,6 @@ def @renderer.after_render(name, props, opts)
7071
test '.new accepts code:' do
7172
dummy_renderer = React::ServerRendering::ExecJSRenderer.new(code: DUMMY_IMPLEMENTATION)
7273
result = dummy_renderer.render("Todo", {todo: "get a real job"}.to_json, {})
73-
assert_equal("renderToString was called", result)
74+
assert_equal("serverRender was called", result)
7475
end
7576
end

test/react/server_rendering/sprockets_renderer_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ class SprocketsRendererTest < ActiveSupport::TestCase
8686
end
8787

8888
test '.new accepts any filenames' do
89-
limited_renderer = React::ServerRendering::SprocketsRenderer.new(files: ["react-server.js", "components/Todo.js"])
89+
limited_renderer = React::ServerRendering::SprocketsRenderer.new(files: ["react-server.js", "react_ujs.js", "components/Todo.js"])
9090
assert_match(/get a real job<\/li>/, limited_renderer.render("Todo", {todo: "get a real job"}, nil))
9191
err = assert_raises React::ServerRendering::PrerenderError do
9292
limited_renderer.render("TodoList", {todos: []}, nil)
@@ -96,7 +96,7 @@ class SprocketsRendererTest < ActiveSupport::TestCase
9696

9797
test '#render returns html when config.assets.compile is false' do
9898
begin
99-
legacy_rendering_files = ["react-server.js", "components.js"]
99+
legacy_rendering_files = ["react-server.js", "react_ujs.js", "components.js"]
100100
Rails.application.config.assets.precompile += legacy_rendering_files
101101

102102
precompile_assets

0 commit comments

Comments
 (0)