Remove test duplication in ReactTest

Author: byroot

Rakefile

@@ -9,15 +9,15 @@ Bundler::GemHelper.install_tasks
 require 'pathname'
 namespace :react do
   task :copy_assets do
-    assets_path = Pathname.new(__dir__).join('lib/assets/react-source/')
+    assets_path = Pathname.new(File.dirname(__FILE__)).join('lib/assets/react-source/')
     copy_react_asset('react.js', assets_path.join('development/react.js'))
     copy_react_asset('react.min.js', assets_path.join('production/react.js'))
     copy_react_asset('react-with-addons.js', assets_path.join('development-with-addons/react.js'))
     copy_react_asset('react-with-addons.min.js', assets_path.join('production-with-addons/react.js'))
   end
 
   def copy_react_asset(source, destination)
-    vendor_path = Pathname.new(__dir__).join('vendor/react')
+    vendor_path = Pathname.new(File.dirname(__FILE__)).join('vendor/react')
     FileUtils.mkdir_p(destination.dirname.to_s)
     FileUtils.cp(vendor_path.join(source), destination.to_s)
   end

test/react_test.rb

@@ -2,8 +2,7 @@
 require 'fileutils'
 
 class ReactTest < ActionDispatch::IntegrationTest
-
-  test 'asset pipeline should deliver react file in a non-production variant' do
+  test 'asset pipeline should deliver drop-in react file replacement' do
     app_react_file_path = File.expand_path("../dummy/vendor/assets/javascripts/react.js",  __FILE__)
 
     react_file_token = "'test_confirmation_token_react_content_non_production';\n";
@@ -17,21 +16,4 @@ class ReactTest < ActionDispatch::IntegrationTest
     assert_response :success
     assert_equal react_file_token, @response.body
   end
-
-  test 'asset pipeline should deliver drop-in react file replacement' do
-    hidden_path = File.expand_path("../dummy/vendor/assets/react/test/react__.js",  __FILE__)
-    replacing_path = File.expand_path("../dummy/vendor/assets/react/test/react.js",  __FILE__)
-
-    FileUtils.mv hidden_path, replacing_path
-    get '/assets/react.js'
-
-    FileUtils.mv replacing_path, hidden_path
-    FileUtils.rm_r CACHE_PATH if CACHE_PATH.exist?
-
-    assert_response :success
-    assert_equal "'test_confirmation_token_react_content';\n", @response.body
-
-    React::Renderer.reset_combined_js!
-  end
-
 end