Skip to content

Commit 3ba4366

Browse files
committed
- Make sure we cleanup transformers properly before and after tests
1 parent 8ab2873 commit 3ba4366

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

test/react/jsx_test.rb

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,17 @@ def transform(code)
2929

3030
class JSXTransformTest < ActionDispatch::IntegrationTest
3131
setup do
32-
clear_sprockets_cache
33-
React::JSX.transformer_class = React::JSX::BabelTransformer
34-
React::JSX.transform_options = {}
32+
reset_transformer
3533
end
3634

3735
teardown do
36+
reset_transformer
37+
end
38+
39+
def reset_transformer
3840
clear_sprockets_cache
41+
React::JSX.transformer_class = React::JSX::BabelTransformer
42+
React::JSX.transform_options = {}
3943
end
4044

4145
test 'asset pipeline should transform JSX' do
@@ -52,7 +56,6 @@ class JSXTransformTest < ActionDispatch::IntegrationTest
5256
# as some version inserts an extra "\n" at the beginning.
5357
# Because appraisal is used, multiple versions of coffee-script are treated
5458
# together. Remove all spaces to make test pass.
55-
# puts @response.body
5659
assert_equal EXPECTED_JS_2.gsub(/\s/, ''), @response.body.gsub(/\s/, '')
5760
end
5861

@@ -76,13 +79,17 @@ def test_babel_transformer_accepts_babel_transformation_options
7679
class JSXTransformerTest < ActionDispatch::IntegrationTest
7780

7881
setup do
79-
clear_sprockets_cache
80-
React::JSX.transformer_class = React::JSX::JSXTransformer
81-
React::JSX.transform_options = {}
82+
reset_transformer
8283
end
8384

8485
teardown do
86+
reset_transformer
87+
end
88+
89+
def reset_transformer
8590
clear_sprockets_cache
91+
React::JSX.transformer_class = React::JSX::JSXTransformer
92+
React::JSX.transform_options = {}
8693
end
8794

8895
test 'can use dropped-in version of JSX transformer' do

0 commit comments

Comments
 (0)