Vendor react assets instead of including react-source

Author: byroot

.bowerrc

@@ -0,0 +1,3 @@
+{
+  "directory" : "vendor/assets/"
+}

.gitignore

@@ -4,3 +4,4 @@ Gemfile.lock
 test/dummy/tmp
 gemfiles/*.lock
 *.swp
+/lib/assets/react-source/

Rakefile

@@ -6,6 +6,27 @@ end
 
 Bundler::GemHelper.install_tasks
 
+require 'pathname'
+require 'react/source'
+
+namespace :react do
+  task :copy_assets do
+    assets_path = Pathname.new(__dir__).join('lib/assets/react-source/')
+    copy_react_asset('react.js', assets_path.join('development/react.js'))
+    copy_react_asset('react.min.js', assets_path.join('production/react.js'))
+    copy_react_asset('react-with-addons.js', assets_path.join('development-with-addons/react.js'))
+    copy_react_asset('react-with-addons.min.js', assets_path.join('production-with-addons/react.js'))
+  end
+
+  def copy_react_asset(source, destination)
+    vendor_path = Pathname.new(__dir__).join('vendor/react')
+    FileUtils.mkdir_p(destination.dirname.to_s)
+    FileUtils.cp(vendor_path.join(source), destination.to_s)
+  end
+end
+
+Rake::Task[:build].enhance(%w(react:copy_assets))
+
 require 'appraisal'
 require 'rake/testtask'
 
@@ -16,5 +37,6 @@ Rake::TestTask.new(:test) do |t|
   t.verbose = ENV['TEST_VERBOSE'] == '1'
   t.warning = true
 end
+Rake::Task[:test].enhance(%w(react:copy_assets))
 
 task default: :test

lib/react/rails/railtie.rb

@@ -28,19 +28,19 @@ class Railtie < ::Rails::Railtie
         end
       end
 
-      initializer "react_rails.setup_vendor", group: :all do |app|
+      config.after_initialize do |app|
         # We want to include different files in dev/prod. The development builds
         # contain console logging for invariants and logging to help catch
         # common mistakes. These are all stripped out in the production build.
 
-        directory = (app.config.react.variant || :production).to_s
-        directory += 'with-addons' if app.config.react.addons
-        app.assets.prepend_path ::React::Source.bundled_path_for(directory)
-        app.assets.prepend_path ::React::Source.bundled_path_for('') # JSXTransformer.js
-      end
+        root_path = Pathname.new('../../../../').expand_path(__FILE__)
 
+        directory = app.config.react.variant == :production ? 'production' : 'development'
+        directory += '-with-addons' if app.config.react.addons
+
+        app.assets.append_path(root_path.join('lib/assets/react-source/').join(directory).to_s)
+        app.assets.append_path(root_path.join('vendor/react/').to_s)
 
-      config.after_initialize do |app|
         # Server Rendering
         # Concat component_filenames together for server rendering
         app.config.react.components_js = lambda {
@@ -59,6 +59,7 @@ class Railtie < ::Rails::Railtie
 
         # Reload the JS VMs in dev when files change
         ActionDispatch::Reloader.to_prepare(&do_setup)
+
       end
 
 

react-rails.gemspec

@@ -23,13 +23,10 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'test-unit', '~> 2.5'
   s.add_development_dependency 'turbolinks', '>= 2.0.0'
 
-
   s.add_dependency 'coffee-script-source', '~>1.8'
   s.add_dependency 'connection_pool'
   s.add_dependency 'execjs'
   s.add_dependency 'rails', '>= 3.1'
-  # If you change this, make sure to update VERSIONS.md:
-  s.add_dependency 'react-source', '~> 0.13'
   s.add_dependency 'tilt'
 
   s.files = Dir[

test/dummy/vendor/assets/javascripts/.gitkeep

@@ -4,15 +4,14 @@
 class ReactTest < ActionDispatch::IntegrationTest
 
   test 'asset pipeline should deliver react file in a non-production variant' do
-    actual_react_file_path = File.expand_path("../dummy/tmp/react-rails/react.js",  __FILE__)
-    actual_react_file_content = File.read actual_react_file_path
+    app_react_file_path = File.expand_path("../dummy/vendor/assets/javascripts/react.js",  __FILE__)
 
     react_file_token = "'test_confirmation_token_react_content_non_production';\n";
-    File.open(actual_react_file_path, 'w') {|f| f.write react_file_token}
+    File.write(app_react_file_path, react_file_token)
 
     get '/assets/react.js'
 
-    File.open(actual_react_file_path, 'w') {|f| f.write actual_react_file_content}
+    File.unlink(app_react_file_path)
     FileUtils.rm_r CACHE_PATH if CACHE_PATH.exist?
 
     assert_response :success

test/react_test.rb

@@ -0,0 +1,17 @@
+{
+  "name": "react",
+  "version": "0.13.2",
+  "main": "react.js",
+  "ignore": [],
+  "homepage": "https://github.com/facebook/react-bower",
+  "_release": "0.13.2",
+  "_resolution": {
+    "type": "version",
+    "tag": "v0.13.2",
+    "commit": "a400da781e82ecac87d69169e4592f1771dee96c"
+  },
+  "_source": "git://github.com/facebook/react-bower.git",
+  "_target": "~0.13.2",
+  "_originalSource": "react",
+  "_direct": true
+}