Skip to content

Review remain pull request #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hg-pyun opened this issue Aug 7, 2019 · 6 comments
Closed

Review remain pull request #161

hg-pyun opened this issue Aug 7, 2019 · 6 comments

Comments

@hg-pyun
Copy link
Member

hg-pyun commented Aug 7, 2019

The remaining PR reviews are not being reviewed for a long time. Please give us your opinion on what to do from now on.

@taehwanno
Copy link
Member

Sorry for the late response. 😢 I think my personal work will be done at the end of September. I will be able to participate actively in October.

@gnujoow
Copy link
Member

gnujoow commented Oct 16, 2019

As personal schedule is over, I can participate more actively from this month.

@hg-pyun
Copy link
Member Author

hg-pyun commented Mar 4, 2020

@taehwanno @gnujoow
The Pull Request is currently being left unattended. Maintainers are too busy to manage. Why don't you lower the limit with an approve?

@taehwanno
Copy link
Member

taehwanno commented Mar 5, 2020

@hg-pyun yes 😢 I agree. I updated the required approving review count to 1.

Lately, I can't actively participate because of a lot of personal work, but I will definitely take the time to participate in this weekend.

@taehwanno
Copy link
Member

@reactjs/reactjs-org-korean-translation When I looked at reactjs/react.dev#3308, the React docs will be likely to change to hooks-first in 2021 early. Although the scope of the change is uncertain, it seems good that the PRs submitted so far are quickly merged. I wonder if you can help :)

@taehwanno
Copy link
Member

Every pull request was closed. So I will close this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants