Skip to content

Start using Draft pull requests for WIP translations #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LucaBlackDragon opened this issue Mar 3, 2019 · 2 comments
Closed

Start using Draft pull requests for WIP translations #119

LucaBlackDragon opened this issue Mar 3, 2019 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@LucaBlackDragon
Copy link
Collaborator

LucaBlackDragon commented Mar 3, 2019

Hi, I've just noticed the new Draft Pull Requests Github feature has been enabled in this repo, so I think we should use it for translations pull requests on which we are still working (maybe together with the "work-in-progress" tag for "backwards compatibility").

In other words, the workflow would be:

  1. Open a Draft Pull Request regarding a new page
  2. Add its reference in the [OLD] Legacy Italian Translation Progress #1
  3. When done translating, convert the Draft Pull Request into a regular Pull Request

For an example of how this would work, please look at my new pull request (#118)

@tesseralis, @deblasis & @lssmn what do you think about it?

@LucaBlackDragon LucaBlackDragon added enhancement New feature or request question Further information is requested labels Mar 3, 2019
@deblasis
Copy link
Collaborator

deblasis commented Mar 3, 2019

Ciao Luca! I see your point but in terms of user experience for new contributors I prefer the issues.
They are just "plug-n-play" and people are used to them:

  1. Pick the one you want by commenting that you want to work on that
  2. When you are done, PR with a comment that says Closes #id_of_the_issue
  3. 💥 done

One way or the other we need to pick one approach, we can't have both because otherwise surely it's gonna be cluttered 🤣

As a side note, I'm surely going to use Draft Pull Requests for when I have to show a POC or something in other projects, instead of adding /wait, /pleasedontmergethiscacca or something. Good shout! 👍

@tesseralis
Copy link
Member

tesseralis commented Mar 3, 2019

Yeah, it's still pretty new, and I don't mind if people start using them in individual pull requests. If people get good mileage out of it I can add it as a suggestion to the maintainer guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants