Skip to content

Add React To A Website Translation #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jan 8, 2022
Merged

Add React To A Website Translation #172

merged 21 commits into from
Jan 8, 2022

Conversation

Anishpras
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the beta label Jan 2, 2022
@Anishpras Anishpras changed the title Two paragraphs translated Add React To A Website - Two Paragraphs translated Jan 2, 2022
@Anishpras Anishpras mentioned this pull request Jan 2, 2022
Closed
@arshadkazmi42 arshadkazmi42 mentioned this pull request Jan 2, 2022
Open
@arshadkazmi42 arshadkazmi42 self-requested a review January 2, 2022 15:29
@arshadkazmi42 arshadkazmi42 added the 1st Review First phase of review label Jan 3, 2022
@Anishpras Anishpras changed the title Add React To A Website - Two Paragraphs translated Add React To A Website Translation Jan 3, 2022
@Anishpras
Copy link
Contributor Author

Hey, @arshadkazmi42 I have completed the translation, can you please review the changes.

@arshadkazmi42
Copy link
Member

Thanks @Anishpras

I will get to is ASAP.

@Anishpras
Copy link
Contributor Author

Thankyou!

@Anishpras
Copy link
Contributor Author

Thanks @Anishpras

I will get to is ASAP.

@arshadkazmi42 Can I translate other pages while you review or should I wait for this PR to be merged?

@arshadkazmi42
Copy link
Member

@Anishpras thank you for quickly working on this.

I think you missed comments added on line 13 you can find those at this link https://github.com/reactjs/hi.reactjs.org/pull/172/files#r780633931

There are 3 comments on that line. Can we get those also fixed.

@Anishpras
Copy link
Contributor Author

@Anishpras thank you for quickly working on this.

I think you missed comments added on line 13 you can find those at this link https://github.com/reactjs/hi.reactjs.org/pull/172/files#r780633931

There are 3 comments on that line. Can we get those also fixed.

@arshadkazmi42 I have fixed those lines.

arshadkazmi42
arshadkazmi42 requested changes Jan 8, 2022
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixes.

Added review for next part of the file till line 88.

Once these are done, I will continue the review for next section.

@Anishpras
Copy link
Contributor Author

@arshadkazmi42 I have done till line number 87.

@arshadkazmi42
Copy link
Member

@Anishpras There was a typo I have unresolved that comment its at line 77 can you check that. गए गए is added two times

@Anishpras
Copy link
Contributor Author

@Anishpras There was a typo I have unresolved that comment its at line 77 can you check that. गए गए is added two times

@arshadkazmi42 I have removed the redundant words.

arshadkazmi42
arshadkazmi42 requested changes Jan 8, 2022
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great going.

Added comments till line 209

@Anishpras
Copy link
Contributor Author

@arshadkazmi42 I have updated till 209.

@arshadkazmi42
Copy link
Member

@Anishpras You missed one and at one line of part got deleted, I have marked those two as unresolved. can you resolved those before continuing further

@Anishpras
Copy link
Contributor Author

@arshadkazmi42 Sorry. I have resolved those lines.

arshadkazmi42
arshadkazmi42 requested changes Jan 8, 2022
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add review for rest of the file. Once these are fixed its good to go from my end

@Anishpras
Copy link
Contributor Author

@arshadkazmi42 I have done all the changes. Thank you for the wonderful reviews.

arshadkazmi42
arshadkazmi42 approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. 🎉

All are resolved. Lets get this merged.

@Anishpras
Copy link
Contributor Author

Great work. 🎉

All are resolved. Lets get this merged.

@arshadkazmi42 Hurray! Thank you for this seamless review process 🚀.

@arshadkazmi42 arshadkazmi42 merged commit 29046f5 into reactjs:main Jan 8, 2022
@Anishpras Anishpras deleted the beta-add-react-to-a-website branch January 8, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arshadkazmi42 arshadkazmi42 arshadkazmi42 approved these changes

Assignees
No one assigned
Labels
1st Review First phase of review beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anishpras @arshadkazmi42