Skip to content

Remove module_from_template #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Archmonger opened this issue Apr 4, 2023 · 4 comments
Closed

Remove module_from_template #965

Archmonger opened this issue Apr 4, 2023 · 4 comments
Labels
priority-3-low May be resolved one any timeline. release-major Warrents a major release type-revision About a change in functionality or behavior
Milestone
2.0.0

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Apr 4, 2023 •
edited
Loading

Current Situation

module_from_template is currently deprecated, and is due for removal. This is a result of random functional issues caused by unpinned ReactJS versions.

Proposed Actions

Remove module_from_template in a future release of reactpy.
@Archmonger Archmonger added priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior release-major Warrents a major release labels Apr 4, 2023
@rmorshea rmorshea added this to the 2.0.0 milestone Apr 5, 2023
@Archmonger
Copy link
Contributor Author

We should do this ASAP

@rmorshea
Copy link
Collaborator

rmorshea commented Jun 7, 2023

This would necessitate a 2.0 release though. It seems like there are other things we might want to break if we're going to do that.

@Archmonger
Copy link
Contributor Author

Archmonger commented Jun 7, 2023 •
edited
Loading

How about this and #993 for 2.0?

That's our two big breaking changes.

3.0 can be the new JS interface.

@Archmonger
Copy link
Contributor Author

Resolved in #1251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-3-low May be resolved one any timeline. release-major Warrents a major release type-revision About a change in functionality or behavior
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@rmorshea @Archmonger