Skip to content

IDOM URL slash safety #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Archmonger opened this issue Apr 19, 2022 · 0 comments · Fixed by #885
Closed

IDOM URL slash safety #744

Archmonger opened this issue Apr 19, 2022 · 0 comments · Fixed by #885
Labels
priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior
Milestone
1.0.0

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Apr 19, 2022 •
edited
Loading

Current Situation

There are some portions of IDOM that currently do not automatically append/prepend forward slashes to URLs.

For example

Proposed Actions

Look through any locations in the source where the user will input a URL.

Automatically append/prepend a forward slash when needed. In Python, an implementation may look like such:

f"/{ my_string.lstrip('/') }"

If a forward slash, or backwards slash, isn't expected in certain situations then we should also be stripping those.
@Archmonger Archmonger added flag-triage Not prioritized. priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior and removed flag-triage Not prioritized. labels Apr 19, 2022
@Archmonger Archmonger added this to the 1.0 milestone Apr 19, 2022
@Archmonger Archmonger changed the title IDOM URL slash saftey IDOM URL slash safety Jul 1, 2022
@rmorshea rmorshea mentioned this issue Jan 24, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-3-low May be resolved one any timeline. type-revision About a change in functionality or behavior
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

check that url prefix starts with / reactive-python/reactpy
1 participant
@Archmonger