Skip to content

Remove Flake8 From Pre-commit #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rmorshea opened this issue Jan 16, 2022 · 0 comments · Fixed by #672
Closed

Remove Flake8 From Pre-commit #595

rmorshea opened this issue Jan 16, 2022 · 0 comments · Fixed by #672
Labels
priority-3-low May be resolved one any timeline. type-contributing About the contributor experience
Milestone
1.0.0

Comments

@rmorshea
Copy link
Collaborator

Current Situation

Right now we run Flake8 in our pre-commit hooks. It would be best if we only ran tools that can automatically fix issues in pre-commit hooks. All other issues will be discovered in CI.

Proposed Actions

Remove Flake8 from pre-commit checks

Work Items

No response
@rmorshea rmorshea added priority-3-low May be resolved one any timeline. type-contributing About the contributor experience labels Jan 16, 2022
@rmorshea rmorshea added this to the 2.0 milestone Jan 16, 2022
@rmorshea rmorshea mentioned this issue Feb 18, 2022
Merged
@Archmonger Archmonger modified the milestones: 2.0, 1.0 Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-3-low May be resolved one any timeline. type-contributing About the contributor experience
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

fix #652 reactive-python/reactpy
2 participants
@rmorshea @Archmonger