Skip to content

Commit 62c6f1f

Browse files
committed
(fix #249) remove extra spaces in element children
1 parent fe56b77 commit 62c6f1f

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

idom/client/app/core_modules/layout.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ function elementChildren(sendEvent, model) {
114114
return model.children.map((child) => {
115115
switch (typeof child) {
116116
case "object":
117-
return html` <${Element} model=${child} sendEvent=${sendEvent} /> `;
117+
return html`<${Element} model=${child} sendEvent=${sendEvent} />`;
118118
case "string":
119119
return child;
120120
}

tests/test_core/test_element.py

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,3 +48,23 @@ def Hello():
4848
display(Hello)
4949

5050
assert driver.find_element_by_id("hello")
51+
52+
53+
def test_pre_tags_are_rendered_correctly(driver, display):
54+
@idom.element
55+
def PreFormated():
56+
return idom.html.pre(
57+
{"id": "pre-form-test"},
58+
idom.html.span("this", idom.html.span("is"), "some"),
59+
"pre-formated",
60+
" text",
61+
)
62+
63+
display(PreFormated)
64+
65+
pre = driver.find_element_by_id("pre-form-test")
66+
67+
assert (
68+
pre.get_attribute("innerHTML")
69+
== "<span>this<span>is</span>some</span>pre-formated text"
70+
)

0 commit comments

Comments
 (0)