Skip to content

Commit 2b34e3d

Browse files
committed
better logs for idom.run + flask server
1 parent 9084467 commit 2b34e3d

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

src/idom/log.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
},
2626
"formatters": {
2727
"generic": {
28-
"format": "%(asctime)s | %(levelname)s | %(name)s | %(message)s",
28+
"format": "%(asctime)s | %(levelname)s | %(message)s",
2929
"datefmt": r"%Y-%m-%dT%H:%M:%S%z",
3030
"class": "logging.Formatter",
3131
}

src/idom/server/flask.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323

2424
from .base import AbstractRenderServer
2525

26+
logger = logging.getLogger(__name__)
27+
2628

2729
class Config(TypedDict, total=False):
2830
"""Render server config for :class:`FlaskRenderServer`"""
@@ -163,7 +165,7 @@ def _generic_run_application(
163165
) -> None:
164166
if debug:
165167
logging.basicConfig(level=logging.DEBUG) # coverage: skip
166-
logging.debug("Starting server...")
168+
logger.info(f"Running at http://{host}:{port}")
167169
self._wsgi_server = _StartCallbackWSGIServer(
168170
self._server_did_start.set,
169171
(host, port),

src/idom/server/prefab.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import logging
12
from typing import Any, Dict, Optional, Tuple, Type, TypeVar
23

34
from idom.core.component import ComponentConstructor
@@ -6,12 +7,13 @@
67
from .base import AbstractRenderServer
78
from .utils import find_available_port, find_builtin_server_type
89

10+
logger = logging.getLogger(__name__)
911
_S = TypeVar("_S", bound=AbstractRenderServer[Any, Any])
1012

1113

1214
def run(
1315
component: ComponentConstructor,
14-
server_type: Optional[Type[_S]] = find_builtin_server_type("PerClientStateServer"),
16+
server_type: Type[_S] = find_builtin_server_type("PerClientStateServer"),
1517
host: str = "127.0.0.1",
1618
port: Optional[int] = None,
1719
server_config: Optional[Any] = None,
@@ -44,11 +46,11 @@ def run(
4446
The server instance. This isn't really useful unless the server is spawned
4547
as a daemon. Otherwise this function blocks until the server has stopped.
4648
"""
47-
if server_type is None: # coverage: skip
48-
raise ValueError("No default server available.")
4949
if port is None: # coverage: skip
5050
port = find_available_port(host)
5151

52+
logger.info(f"Using {server_type.__module__}.{server_type.__name__}")
53+
5254
server = server_type(component, server_config)
5355

5456
if app is not None: # coverage: skip

0 commit comments

Comments
 (0)