Skip to content

Make resources implement AutoCloseable #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acogoluegnes opened this issue Aug 29, 2016 · 5 comments
Closed

Make resources implement AutoCloseable #185

acogoluegnes opened this issue Aug 29, 2016 · 5 comments

Comments

@acogoluegnes
Copy link
Contributor

When we drop Java 1.6 compliance.

@vikinghawk
Copy link
Contributor

Do you guys have a release in mind where you would drop 1.6 support? Unfortunately my team will be stuck on 1.6 for awhile longer so just wondering when this might become an issue for us. Thanks

@michaelklishin
Copy link
Contributor

When Spring does in Spring 5.

On 30 Sep 2016, at 20:54, vikinghawk [email protected] wrote:

Do you guys have a release in mind where you would drop 1.6 support? Unfortunately my team will be stuck on 1.6 for awhile longer so just wondering when this might become an issue for us. Thanks


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@kabl
Copy link

kabl commented Nov 14, 2016

Why not implement Closeable? Is there since 1.5.

@acogoluegnes
Copy link
Contributor Author

Yes, Closeable could also work (it's actually implemented by Connection), but it wouldn't for Channel. This issue is more of a reminder to see what we can do regarding auto-closeable resources (mainly Connection and Channel, but there may other places where it could be appropriate) when we drop Java 1.6 support.

@acogoluegnes acogoluegnes added this to the 5.0.0 milestone Feb 20, 2017
@acogoluegnes
Copy link
Contributor Author

Closing now #258 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants