Fix OID inequality comparison

Due to an extraneous 'or' branch, OID inequality
comparison would return the results of an equality
comparison.

Signed-off-by: Alexander Scheel <[email protected]>

Author: cipherboy

gssapi/raw/oids.pyx

@@ -155,7 +155,7 @@ cdef class OID:
         return hash(self.__bytes__())
 
     def __richcmp__(OID self, OID other, op):
-        if op == 2 or op == 3:  # ==
+        if op == 2:  # ==
             return c_compare_oids(&self.raw_oid, &other.raw_oid)
         elif op == 3:  # !=
             return not c_compare_oids(&self.raw_oid, &other.raw_oid)

gssapi/tests/test_raw.py

@@ -1353,3 +1353,20 @@ def test_encode_from_int_seq(self):
             int_seq = oid['string'].split('.')
             o = gb.OID.from_int_seq(int_seq)
             o.__bytes__().should_be(oid['bytes'])
+
+    def test_comparisons(self):
+        krb5 = gb.OID.from_int_seq(TEST_OIDS['KRB5']['string'])
+        krb5_other = gb.OID.from_int_seq(TEST_OIDS['KRB5']['string'])
+        spnego = gb.OID.from_int_seq(TEST_OIDS['SPNEGO']['string'])
+
+        a = krb5 == krb5_other
+        a.should_be(True)
+
+        a = krb5 == spnego
+        a.should_be(False)
+
+        a = krb5 != krb5_other
+        a.should_be(False)
+
+        a = krb5 != spnego
+        a.should_be(True)