Skip to content

Commit 4e7f4b0

Browse files
author
v.shepard
committed
merge master
2 parents 12aa7ba + 09e9f01 commit 4e7f4b0

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

testgres/operations/local_ops.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import stat
55
import subprocess
66
import tempfile
7-
from shutil import rmtree
87

98
import psutil
109

@@ -14,8 +13,11 @@
1413

1514
try:
1615
from shutil import which as find_executable
16+
from shutil import rmtree
1717
except ImportError:
1818
from distutils.spawn import find_executable
19+
from distutils import rmtree
20+
1921

2022
CMD_TIMEOUT_SEC = 60
2123
error_markers = [b'error', b'Permission denied', b'fatal']

testgres/utils.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
import sys
99

1010
from contextlib import contextmanager
11-
from packaging.version import Version
11+
from packaging.version import Version, InvalidVersion
12+
import re
1213

1314
from six import iteritems
1415

@@ -21,8 +22,15 @@
2122
# ports used by nodes
2223
bound_ports = set()
2324

25+
2426
# re-export version type
25-
PgVer = Version
27+
class PgVer(Version):
28+
def __init__(self, version: str) -> None:
29+
try:
30+
super().__init__(version)
31+
except InvalidVersion:
32+
version = re.sub(r"[a-zA-Z].*", "", version)
33+
super().__init__(version)
2634

2735

2836
def reserve_port():

tests/test_simple.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -901,13 +901,21 @@ def test_version_management(self):
901901
d = PgVer('15.0')
902902
e = PgVer('15rc1')
903903
f = PgVer('15beta4')
904+
h = PgVer('15.3biha')
905+
i = PgVer('15.3')
906+
g = PgVer('15.3.1bihabeta1')
907+
k = PgVer('15.3.1')
904908

905909
self.assertTrue(a == b)
906910
self.assertTrue(b > c)
907911
self.assertTrue(a > c)
908912
self.assertTrue(d > e)
909913
self.assertTrue(e > f)
910914
self.assertTrue(d > f)
915+
self.assertTrue(h > f)
916+
self.assertTrue(h == i)
917+
self.assertTrue(g == k)
918+
self.assertTrue(g > h)
911919

912920
version = get_pg_version()
913921
with get_new_node() as node:

0 commit comments

Comments
 (0)