Skip to content

Commit 92fce4e

Browse files
committed
Reduce warnings with -Wshadow=compatible-local builds
In a similar effort to f01592f, here we further reduce the warnings we get about local variables being shadowed when building with -Wshadow=compatible-local. This small change reduces the overall number of warnings by 36. Discussion: https://postgr.es/m/CAApHDvqBBqF=wmV5azrO7h3VwpwQo+JFBQ+g=E6wVUhKcqR8gA@mail.gmail.com
1 parent f01592f commit 92fce4e

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/test/regress/regress.c

+8-8
Original file line numberDiff line numberDiff line change
@@ -56,22 +56,22 @@
5656

5757
#define EXPECT_EQ_U32(result_expr, expected_expr) \
5858
do { \
59-
uint32 result = (result_expr); \
60-
uint32 expected = (expected_expr); \
61-
if (result != expected) \
59+
uint32 actual_result = (result_expr); \
60+
uint32 expected_result = (expected_expr); \
61+
if (actual_result != expected_result) \
6262
elog(ERROR, \
6363
"%s yielded %u, expected %s in file \"%s\" line %u", \
64-
#result_expr, result, #expected_expr, __FILE__, __LINE__); \
64+
#result_expr, actual_result, #expected_expr, __FILE__, __LINE__); \
6565
} while (0)
6666

6767
#define EXPECT_EQ_U64(result_expr, expected_expr) \
6868
do { \
69-
uint64 result = (result_expr); \
70-
uint64 expected = (expected_expr); \
71-
if (result != expected) \
69+
uint64 actual_result = (result_expr); \
70+
uint64 expected_result = (expected_expr); \
71+
if (actual_result != expected_result) \
7272
elog(ERROR, \
7373
"%s yielded " UINT64_FORMAT ", expected %s in file \"%s\" line %u", \
74-
#result_expr, result, #expected_expr, __FILE__, __LINE__); \
74+
#result_expr, actual_result, #expected_expr, __FILE__, __LINE__); \
7575
} while (0)
7676

7777
#define LDELIM '('

0 commit comments

Comments
 (0)