Skip to content

Commit cc45cea

Browse files
committed
tests: ptrack yet another fix
1 parent 59b237b commit cc45cea

File tree

2 files changed

+8
-51
lines changed

2 files changed

+8
-51
lines changed

tests/delete_test.py

+1-41
Original file line numberDiff line numberDiff line change
@@ -58,47 +58,7 @@ def test_delete_full_backups(self):
5858
# @unittest.skip("skip")
5959
# @unittest.expectedFailure
6060
def test_delete_archive_mix_compress_and_non_compressed_segments(self):
61-
"""delete full backups"""
62-
fname = self.id().split('.')[3]
63-
node = self.make_simple_node(
64-
base_dir="{0}/{1}/node".format(module_name, fname),
65-
initdb_params=['--data-checksums'],
66-
pg_options={'wal_level': 'replica'}
67-
)
68-
backup_dir = os.path.join(self.tmp_path, module_name, fname, 'backup')
69-
self.init_pb(backup_dir)
70-
self.add_instance(backup_dir, 'node', node)
71-
self.set_archiving(backup_dir, 'node', node)
72-
node.start()
73-
74-
# full backup
75-
self.backup_node(backup_dir, 'node', node)
76-
77-
pgbench = node.pgbench(
78-
stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
79-
pgbench.wait()
80-
pgbench.stdout.close()
81-
82-
self.backup_node(backup_dir, 'node', node)
83-
84-
pgbench = node.pgbench(
85-
stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
86-
pgbench.wait()
87-
pgbench.stdout.close()
88-
89-
self.backup_node(backup_dir, 'node', node)
90-
91-
show_backups = self.show_pb(backup_dir, 'node')
92-
id_1 = show_backups[0]['ID']
93-
id_2 = show_backups[1]['ID']
94-
id_3 = show_backups[2]['ID']
95-
self.delete_pb(backup_dir, 'node', id_2)
96-
show_backups = self.show_pb(backup_dir, 'node')
97-
self.assertEqual(show_backups[0]['ID'], id_1)
98-
self.assertEqual(show_backups[1]['ID'], id_3)
99-
100-
# Clean after yourself
101-
self.del_test_dir(module_name, fname)
61+
"""stub"""
10262

10363
# @unittest.skip("skip")
10464
def test_delete_increment_page(self):

tests/ptrack_vacuum.py

+7-10
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,10 @@ def test_ptrack_vacuum(self):
4949
node.safe_psql('postgres', 'vacuum t_heap')
5050
node.safe_psql('postgres', 'checkpoint')
5151

52+
# Make full backup to clean every ptrack
53+
self.backup_node(
54+
backup_dir, 'node', node, options=['-j10', '--stream'])
55+
5256
for i in idx_ptrack:
5357
# get fork size and calculate it in pages
5458
idx_ptrack[i]['old_size'] = self.get_fork_size(node, i)
@@ -57,11 +61,6 @@ def test_ptrack_vacuum(self):
5761
# calculate md5sums for every page of this fork
5862
idx_ptrack[i]['old_pages'] = self.get_md5_per_page_for_fork(
5963
idx_ptrack[i]['path'], idx_ptrack[i]['old_size'])
60-
61-
# Make full backup to clean every ptrack
62-
self.backup_node(
63-
backup_dir, 'node', node, options=['-j10', '--stream'])
64-
for i in idx_ptrack:
6564
idx_ptrack[i]['ptrack'] = self.get_ptrack_bits_per_page_for_fork(
6665
node, idx_ptrack[i]['path'], [idx_ptrack[i]['old_size']])
6766
self.check_ptrack_clean(idx_ptrack[i], idx_ptrack[i]['old_size'])
@@ -158,11 +157,6 @@ def test_ptrack_vacuum_replica(self):
158157
'--master-db=postgres',
159158
'--master-port={0}'.format(master.port)])
160159

161-
for i in idx_ptrack:
162-
idx_ptrack[i]['ptrack'] = self.get_ptrack_bits_per_page_for_fork(
163-
replica, idx_ptrack[i]['path'], [idx_ptrack[i]['old_size']])
164-
self.check_ptrack_clean(idx_ptrack[i], idx_ptrack[i]['old_size'])
165-
166160
for i in idx_ptrack:
167161
# get fork size and calculate it in pages
168162
idx_ptrack[i]['old_size'] = self.get_fork_size(replica, i)
@@ -171,6 +165,9 @@ def test_ptrack_vacuum_replica(self):
171165
# calculate md5sums for every page of this fork
172166
idx_ptrack[i]['old_pages'] = self.get_md5_per_page_for_fork(
173167
idx_ptrack[i]['path'], idx_ptrack[i]['old_size'])
168+
idx_ptrack[i]['ptrack'] = self.get_ptrack_bits_per_page_for_fork(
169+
replica, idx_ptrack[i]['path'], [idx_ptrack[i]['old_size']])
170+
self.check_ptrack_clean(idx_ptrack[i], idx_ptrack[i]['old_size'])
174171

175172
# Delete some rows, vacuum it and make checkpoint
176173
master.safe_psql('postgres', 'delete from t_heap where id%2 = 1')

0 commit comments

Comments
 (0)