Skip to content

tests are not passing #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
antoinerg opened this issue Nov 19, 2018 · 2 comments
Closed

tests are not passing #112

antoinerg opened this issue Nov 19, 2018 · 2 comments
Assignees
@antoinerg

Comments

@antoinerg
Copy link
Contributor

antoinerg commented Nov 19, 2018 •
edited
Loading

On master, npm i && npm run test fails with

  86:5  error  componentWillUpdate is deprecated since React 16.3.0, use UNSAFE_componentWillUpdate instead, see https://reactjs.org/docs/react-component.html#unsafe_componentwillupdate  react/no-deprecated
@antoinerg antoinerg self-assigned this Nov 19, 2018
@antoinerg antoinerg mentioned this issue Nov 19, 2018
Merged
@nicolaskruchten
Copy link
Contributor

let's pin React in package.json then?

@antoinerg
Copy link
Contributor Author

antoinerg commented Nov 19, 2018 •
edited
Loading

I think it's already pinned in package.json but it seems like the linter also needs to be told what version to use. Running the linter on master yields this warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoinerg antoinerg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolaskruchten @antoinerg