Skip building JS assets except in plotlyjs_dev_build

Author: Frédéric Collonval

.circleci/config.yml

@@ -26,10 +26,12 @@ jobs:
       - checkout
       - run:
           name: Install tox
-          command: "sudo pip install tox jupyterlab~=3.0"
+          command: "sudo pip install tox"
       - run:
           name: Test with tox
           command: "cd packages/python/plotly; tox -e py27-core"
+          environment:
+            SKIP_NPM: 1
           no_output_timeout: 20m
 
   python-3.5-core:
@@ -43,10 +45,12 @@ jobs:
       - checkout
       - run:
           name: Install tox
-          command: "sudo pip install tox jupyterlab~=3.0"
+          command: "sudo pip install tox"
       - run:
           name: Test with tox
           command: "cd packages/python/plotly; tox -e py35-core"
+          environment:
+            SKIP_NPM: 1
           no_output_timeout: 20m
 
   python-3.6-core:
@@ -60,10 +64,12 @@ jobs:
       - checkout
       - run:
           name: Install tox
-          command: "sudo pip install tox jupyterlab~=3.0"
+          command: "sudo pip install tox"
       - run:
           name: Test with tox
           command: "cd packages/python/plotly; tox -e py36-core"
+          environment:
+            SKIP_NPM: 1
           no_output_timeout: 20m
 
   python-3.7-core:
@@ -77,10 +83,12 @@ jobs:
       - checkout
       - run:
           name: Install tox
-          command: "sudo pip install tox jupyterlab~=3.0"
+          command: "sudo pip install tox"
       - run:
           name: Test with tox
           command: "cd packages/python/plotly; tox -e py37-core"
+          environment:
+            SKIP_NPM: 1
           no_output_timeout: 20m
 
   python-3.7-percy:
@@ -128,10 +136,12 @@ jobs:
       - checkout
       - run:
           name: Install tox
-          command: "sudo pip install tox jupyterlab~=3.0"
+          command: "sudo pip install tox"
       - run:
           name: Test with tox
           command: "cd packages/python/plotly; tox -e py27-optional"
+          environment:
+            SKIP_NPM: 1
           no_output_timeout: 20m
 
   python-3.5-optional:
@@ -145,10 +155,12 @@ jobs:
       - checkout
       - run:
           name: Install tox
-          command: "sudo pip install tox jupyterlab~=3.0"
+          command: "sudo pip install tox"
       - run:
           name: Test with tox
           command: "cd packages/python/plotly; tox -e py35-optional"
+          environment:
+            SKIP_NPM: 1
           no_output_timeout: 20m
 
   python-3.6-optional:
@@ -162,10 +174,12 @@ jobs:
       - checkout
       - run:
           name: Install tox
-          command: "sudo pip install tox jupyterlab~=3.0"
+          command: "sudo pip install tox"
       - run:
           name: Test with tox
           command: "cd packages/python/plotly; tox -e py36-optional"
+          environment:
+            SKIP_NPM: 1
           no_output_timeout: 20m
 
   python-3.7-optional:
@@ -179,10 +193,12 @@ jobs:
       - checkout
       - run:
           name: Install tox
-          command: "sudo pip install tox jupyterlab~=3.0"
+          command: "sudo pip install tox"
       - run:
           name: Test with tox
           command: "cd packages/python/plotly; tox -e py37-optional"
+          environment:
+            SKIP_NPM: 1
           no_output_timeout: 20m
 
   # Plot.ly
@@ -197,10 +213,12 @@ jobs:
       - checkout
       - run:
           name: Install tox
-          command: "sudo pip install tox jupyterlab~=3.0"
+          command: "sudo pip install tox"
       - run:
           name: Test with tox
           command: "cd packages/python/chart-studio; tox -e py27-plot_ly"
+          environment:
+            SKIP_NPM: 1
           no_output_timeout: 20m
 
   python-3.5-plot_ly:
@@ -214,10 +232,12 @@ jobs:
       - checkout
       - run:
           name: Install tox
-          command: "sudo pip install tox jupyterlab~=3.0"
+          command: "sudo pip install tox"
       - run:
           name: Test with tox
           command: "cd packages/python/chart-studio; tox -e py35-plot_ly"
+          environment:
+            SKIP_NPM: 1
           no_output_timeout: 20m
 
   python-3.7-plot_ly:
@@ -231,10 +251,12 @@ jobs:
       - checkout
       - run:
           name: Install tox
-          command: "sudo pip install tox jupyterlab~=3.0"
+          command: "sudo pip install tox"
       - run:
           name: Test with tox
           command: "cd packages/python/chart-studio; tox -e py37-plot_ly"
+          environment:
+            SKIP_NPM: 1
           no_output_timeout: 20m
 
   python-2-7-orca:

packages/python/chart-studio/tox.ini

@@ -45,7 +45,7 @@ envlist = py{27,34,37}-plot_ly
 
 ; These commands are general and will be run for *all* environments.
 [testenv]
-passenv=PLOTLY_TOX_*
+passenv=PLOTLY_TOX_* SKIP_NPM
 whitelist_externals=
     mkdir
 deps=

packages/python/plotly/setup.py

@@ -29,6 +29,17 @@
 )
 
 labstatic = "plotlywidget/labextension/static"
+if not os.path.exists(labstatic):
+    # Ensure the folder exists when we will look for files in it
+    os.makedirs(labstatic)
+
+if "--skip-npm" in sys.argv or os.environ.get("SKIP_NPM") is not None:
+    print("Skipping npm install as requested.")
+    skip_npm = True
+    if "--skip-npm" in sys.argv:
+        sys.argv.remove("--skip-npm")
+else:
+    skip_npm = False
 
 # Load plotly.js version from js/package.json
 def plotly_js_version():
@@ -133,6 +144,10 @@ def should_run_npm_install(self):
         return self.has_npm()
 
     def run(self):
+        if skip_npm:
+            log.info("Skipping npm-installation")
+            return
+
         has_npm = self.has_npm()
         if not has_npm:
             log.error(

packages/python/plotly/tox.ini

@@ -45,7 +45,7 @@ envlist = py{27,34,35,36,37}-{core,optional},py{27,34,37}
 
 ; These commands are general and will be run for *all* environments.
 [testenv]
-passenv=PLOTLY_TOX_*
+passenv=PLOTLY_TOX_* SKIP_NPM
 whitelist_externals=
     mkdir
 deps=