From f8065b86b9f4c3c39896b8c394f31118e0b2c819 Mon Sep 17 00:00:00 2001 From: Martha Cryan Date: Tue, 25 Jun 2024 13:45:26 -0700 Subject: [PATCH 1/2] Update CONTRIBUTING.md --- CONTRIBUTING.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b9414f7d2fa..d7306a24851 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -77,12 +77,14 @@ We use the following [labels](https://github.com/plotly/plotly.js/labels) to tra #### Prerequisites - git -- [node.js](https://nodejs.org/en/). We recommend using node.js v16.x. +- [node.js](https://nodejs.org/en/). We recommend using node.js v20.x. Upgrading and managing node versions can be easily done using [`nvm`](https://github.com/creationix/nvm) or its Windows alternatives. - [`npm`](https://www.npmjs.com/) v7.x and up to ensure that the [`package-lock.json`](https://docs.npmjs.com/files/package-lock.json) file is used and updated correctly. +- [`python3`](https://www.python.org/downloads/) +Note: for M1 mac users specifically, you might need to install some [extra dependencies](https://github.com/Automattic/node-canvas/issues/1733#issuecomment-761703018). #### Step 1: Fork the plotly.js repository, clone your fork and step into it From 965efb64d90453d9e4b2a4830bb1be065f47465b Mon Sep 17 00:00:00 2001 From: Martha Cryan Date: Mon, 12 Aug 2024 14:56:05 -0500 Subject: [PATCH 2/2] Undo change to minimum node version --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d7306a24851..a036febeff7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -77,7 +77,7 @@ We use the following [labels](https://github.com/plotly/plotly.js/labels) to tra #### Prerequisites - git -- [node.js](https://nodejs.org/en/). We recommend using node.js v20.x. +- [node.js](https://nodejs.org/en/). We recommend using node.js v16.x. Upgrading and managing node versions can be easily done using [`nvm`](https://github.com/creationix/nvm) or its Windows alternatives. - [`npm`](https://www.npmjs.com/) v7.x and up to ensure that the