Skip to content

Commit f7d637d

Browse files
committed
📚 link TODOs to gh issues
1 parent 980855c commit f7d637d

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

src/plot_api/plot_api.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1693,10 +1693,14 @@ exports.relayout = function relayout(gd, astr, val) {
16931693
// no test fail when commenting out doAutoRangeAndConstraints,
16941694
// but I think we do need this (maybe just the enforce part?)
16951695
// Am I right?
1696+
// More info in:
1697+
// https://github.com/plotly/plotly.js/issues/2540
16961698
subroutines.doAutoRangeAndConstraints,
16971699
// TODO
16981700
// can target specific axes,
16991701
// do not have to redraw all axes here
1702+
// See:
1703+
// https://github.com/plotly/plotly.js/issues/2547
17001704
subroutines.doTicksRelayout,
17011705
subroutines.drawData,
17021706
subroutines.finalDraw

src/plot_api/subroutines.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,6 @@ exports.drawData = function(gd) {
525525
}
526526
}
527527

528-
// TODO does this break or slow down parcoords??
529528
clearGlCanvases(gd);
530529

531530
// loop over the base plot modules present on graph

src/plots/cartesian/dragbox.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -788,7 +788,8 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
788788
.call(Drawing.setScale, 1 / xScaleFactor2, 1 / yScaleFactor2);
789789

790790
// TODO move these selectAll calls out of here
791-
// and stash them somewhere nice.
791+
// and stash them somewhere nice, see:
792+
// https://github.com/plotly/plotly.js/issues/2548
792793
if(hasDraggedPts) {
793794
var traceGroups = sp.plot
794795
.selectAll('.scatterlayer .trace, .boxlayer .trace, .violinlayer .trace');

0 commit comments

Comments
 (0)