Throw an error when redraw called on invalid gd

rreusser · rreusser · commit e3ccac51c57d · 2016-09-06T12:33:24.000-06:00
diff --git a/src/plot_api/plot_api.js b/src/plot_api/plot_api.js
@@ -823,8 +823,7 @@ Plotly.redraw = function(gd) {
     gd = getGraphDiv(gd);
 
     if(!Lib.isPlotDiv(gd)) {
-        Lib.warn('This element is not a Plotly plot.', gd);
-        return;
+        throw new Error('This element is not a Plotly plot: ' + gd);
     }
 
     gd.calcdata = undefined;

Original file line number	Diff line number	Diff line change
`@@ -823,8 +823,7 @@ Plotly.redraw = function(gd) {`
`823`	`823`	`gd = getGraphDiv(gd);`
`824`	`824`
`825`	`825`	`if(!Lib.isPlotDiv(gd)) {`
`826`		`- Lib.warn('This element is not a Plotly plot.', gd);`
`827`		`- return;`
	`826`	`+ throw new Error('This element is not a Plotly plot: ' + gd);`
`828`	`827`	`}`
`829`	`828`
`830`	`829`	`gd.calcdata = undefined;`