Skip to content

Commit c82da07

Browse files
committed
rewrite without forEach
1 parent 41504aa commit c82da07

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

src/traces/isosurface/calc.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@ module.exports = function calc(gd, trace) {
2020
trace.value.length
2121
);
2222

23-
['value', 'x', 'y', 'z'].forEach(function(e) {
24-
trace['_' + e] = filter(trace[e], trace._len);
25-
});
23+
trace._x = filter(trace.x, trace._len);
24+
trace._y = filter(trace.y, trace._len);
25+
trace._z = filter(trace.z, trace._len);
26+
trace._value = filter(trace.value, trace._len);
2627

2728
var grid = processGrid(trace);
2829
trace._gridFill = grid.fill;

src/traces/streamtube/calc.js

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,20 @@ var colorscaleCalc = require('../../components/colorscale/calc');
1313

1414
function calc(gd, trace) {
1515
trace._len = Math.min(
16-
trace.x.length,
17-
trace.y.length,
18-
trace.z.length,
1916
trace.u.length,
2017
trace.v.length,
21-
trace.w.length
18+
trace.w.length,
19+
trace.x.length,
20+
trace.y.length,
21+
trace.z.length
2222
);
2323

24-
['u', 'v', 'w', 'x', 'y', 'z'].forEach(function(e) {
25-
trace['_' + e] = filter(trace[e], trace._len);
26-
});
24+
trace._u = filter(trace.u, trace._len);
25+
trace._v = filter(trace.v, trace._len);
26+
trace._w = filter(trace.w, trace._len);
27+
trace._x = filter(trace.x, trace._len);
28+
trace._y = filter(trace.y, trace._len);
29+
trace._z = filter(trace.z, trace._len);
2730

2831
var grid = processGrid(trace);
2932
trace._gridFill = grid.fill;

0 commit comments

Comments
 (0)