Skip to content

Commit bf6793e

Browse files
committed
write promise sequence as promise chains
1 parent dc72d33 commit bf6793e

File tree

2 files changed

+49
-45
lines changed

2 files changed

+49
-45
lines changed

test/jasmine/tests/geo_interact_test.js

Lines changed: 27 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -201,11 +201,12 @@ describe('Test geo interactions', function() {
201201
expect(countTraces('scattergeo')).toBe(0);
202202
expect(countTraces('choropleth')).toBe(1);
203203

204-
Plotly.restyle(gd, 'visible', true, [0]).then(function() {
205-
expect(countTraces('scattergeo')).toBe(1);
206-
expect(countTraces('choropleth')).toBe(1);
207-
done();
208-
});
204+
return Plotly.restyle(gd, 'visible', true, [0]);
205+
}).then(function() {
206+
expect(countTraces('scattergeo')).toBe(1);
207+
expect(countTraces('choropleth')).toBe(1);
208+
209+
done();
209210
});
210211
});
211212

@@ -217,11 +218,12 @@ describe('Test geo interactions', function() {
217218
expect(countTraces('scattergeo')).toBe(1);
218219
expect(countTraces('choropleth')).toBe(0);
219220

220-
Plotly.restyle(gd, 'visible', true, [1]).then(function() {
221-
expect(countTraces('scattergeo')).toBe(1);
222-
expect(countTraces('choropleth')).toBe(1);
223-
done();
224-
});
221+
return Plotly.restyle(gd, 'visible', true, [1]);
222+
}).then(function() {
223+
expect(countTraces('scattergeo')).toBe(1);
224+
expect(countTraces('choropleth')).toBe(1);
225+
226+
done();
225227
});
226228
});
227229

@@ -240,20 +242,21 @@ describe('Test geo interactions', function() {
240242
expect(countGeos()).toBe(1);
241243
expect(countColorBars()).toBe(1);
242244

243-
Plotly.deleteTraces(gd, [0]).then(function() {
244-
expect(countTraces('scattergeo')).toBe(0);
245-
expect(countTraces('choropleth')).toBe(0);
246-
expect(countGeos()).toBe(1);
247-
expect(countColorBars()).toBe(0);
248-
249-
Plotly.relayout(gd, 'geo', null).then(function() {
250-
expect(countTraces('scattergeo')).toBe(0);
251-
expect(countTraces('choropleth')).toBe(0);
252-
expect(countGeos()).toBe(0);
253-
expect(countColorBars()).toBe(0);
254-
done();
255-
});
256-
});
245+
return Plotly.deleteTraces(gd, [0]);
246+
}).then(function() {
247+
expect(countTraces('scattergeo')).toBe(0);
248+
expect(countTraces('choropleth')).toBe(0);
249+
expect(countGeos()).toBe(1);
250+
expect(countColorBars()).toBe(0);
251+
252+
return Plotly.relayout(gd, 'geo', null);
253+
}).then(function() {
254+
expect(countTraces('scattergeo')).toBe(0);
255+
expect(countTraces('choropleth')).toBe(0);
256+
expect(countGeos()).toBe(0);
257+
expect(countColorBars()).toBe(0);
258+
259+
done();
257260
});
258261
});
259262
});

test/jasmine/tests/plot_interact_test.js

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -206,27 +206,28 @@ describe('Test plot structure', function() {
206206
assertContourNodes(2);
207207
expect(countColorBars()).toEqual(0);
208208

209-
Plotly.deleteTraces(gd, [0]).then(function() {
210-
expect(countSubplots()).toEqual(4);
211-
assertHeatmapNodes(2);
212-
assertContourNodes(2);
213-
expect(countColorBars()).toEqual(0);
214-
215-
Plotly.deleteTraces(gd, [0]).then(function() {
216-
expect(countSubplots()).toEqual(4);
217-
assertHeatmapNodes(1);
218-
assertContourNodes(1);
219-
expect(countColorBars()).toEqual(0);
220-
221-
Plotly.deleteTraces(gd, [0]).then(function() {
222-
expect(countSubplots()).toEqual(4);
223-
assertHeatmapNodes(0);
224-
assertContourNodes(0);
225-
expect(countColorBars()).toEqual(0);
226-
done();
227-
});
228-
});
229-
});
209+
return Plotly.deleteTraces(gd, [0]);
210+
}).then(function() {
211+
expect(countSubplots()).toEqual(4);
212+
assertHeatmapNodes(2);
213+
assertContourNodes(2);
214+
expect(countColorBars()).toEqual(0);
215+
216+
return Plotly.deleteTraces(gd, [0]);
217+
}).then(function() {
218+
expect(countSubplots()).toEqual(4);
219+
assertHeatmapNodes(1);
220+
assertContourNodes(1);
221+
expect(countColorBars()).toEqual(0);
222+
223+
return Plotly.deleteTraces(gd, [0]);
224+
}).then(function() {
225+
expect(countSubplots()).toEqual(4);
226+
assertHeatmapNodes(0);
227+
assertContourNodes(0);
228+
expect(countColorBars()).toEqual(0);
229+
230+
done();
230231
});
231232
});
232233

0 commit comments

Comments
 (0)