Skip to content

Commit abcf1b0

Browse files
committed
register fx in core.js
- this removes one more circular dep!
1 parent a96af57 commit abcf1b0

File tree

4 files changed

+3
-6
lines changed

4 files changed

+3
-6
lines changed

src/core.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ exports.register(require('./traces/scatter'));
5353

5454
// register all registrable components modules
5555
exports.register([
56+
require('./components/fx'),
5657
require('./components/legend'),
5758
require('./components/annotations'),
5859
require('./components/shapes'),
@@ -68,7 +69,7 @@ exports.Icons = require('../build/ploticon');
6869

6970
// unofficial 'beta' plot methods, use at your own risk
7071
exports.Plots = Plotly.Plots;
71-
exports.Fx = Plotly.Fx;
72+
exports.Fx = require('./components/fx');
7273
exports.Snapshot = require('./snapshot');
7374
exports.PlotSchema = require('./plot_api/plot_schema');
7475
exports.Queue = require('./lib/queue');

src/plotly.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ exports.Axes = require('./plots/cartesian/axes');
2727

2828
// components
2929
exports.ModeBar = require('./components/modebar');
30-
exports.Fx = require('./components/fx');
3130

3231
// plot api
3332
require('./plot_api/plot_api');

src/plots/plots.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1111,9 +1111,6 @@ plots.supplyLayoutModuleDefaults = function(layoutIn, layoutOut, fullData, trans
11111111
}
11121112
}
11131113

1114-
// should FX be a component?
1115-
Plotly.Fx.supplyLayoutDefaults(layoutIn, layoutOut, fullData);
1116-
11171114
var components = Object.keys(Registry.componentsRegistry);
11181115
for(i = 0; i < components.length; i++) {
11191116
_module = Registry.componentsRegistry[components[i]];

tasks/test_syntax.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ function assertCircularDeps() {
177177
var logs = [];
178178

179179
// see https://github.com/plotly/plotly.js/milestone/9
180-
var MAX_ALLOWED_CIRCULAR_DEPS = 13;
180+
var MAX_ALLOWED_CIRCULAR_DEPS = 12;
181181

182182
if(circularDeps.length > MAX_ALLOWED_CIRCULAR_DEPS) {
183183
console.log(circularDeps.join('\n'));

0 commit comments

Comments
 (0)