Skip to content

Commit 83c2722

Browse files
committed
replace unnecessary === undefined check in Plots
by simple `!` checks
1 parent bfb05d4 commit 83c2722

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/plots/plots.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ plots.hasSimpleAPICommandBindings = commandModule.hasSimpleAPICommandBindings;
6363
plots.findSubplotIds = function findSubplotIds(data, type) {
6464
var subplotIds = [];
6565

66-
if(plots.subplotsRegistry[type] === undefined) return subplotIds;
66+
if(!plots.subplotsRegistry[type]) return subplotIds;
6767

6868
var attr = plots.subplotsRegistry[type].attr;
6969

@@ -90,7 +90,7 @@ plots.findSubplotIds = function findSubplotIds(data, type) {
9090
plots.getSubplotIds = function getSubplotIds(layout, type) {
9191
var _module = plots.subplotsRegistry[type];
9292

93-
if(_module === undefined) return [];
93+
if(!_module) return [];
9494

9595
// layout must be 'fullLayout' here
9696
if(type === 'cartesian' && (!layout._has || !layout._has('cartesian'))) return [];
@@ -131,7 +131,7 @@ plots.getSubplotIds = function getSubplotIds(layout, type) {
131131
*
132132
*/
133133
plots.getSubplotData = function getSubplotData(data, type, subplotId) {
134-
if(plots.subplotsRegistry[type] === undefined) return [];
134+
if(!plots.subplotsRegistry[type]) return [];
135135

136136
var attr = plots.subplotsRegistry[type].attr,
137137
subplotData = [],
@@ -167,7 +167,7 @@ plots.getSubplotData = function getSubplotData(data, type, subplotId) {
167167
* @return {array} array of calcdata traces
168168
*/
169169
plots.getSubplotCalcData = function(calcData, type, subplotId) {
170-
if(plots.subplotsRegistry[type] === undefined) return [];
170+
if(!plots.subplotsRegistry[type]) return [];
171171

172172
var attr = plots.subplotsRegistry[type].attr;
173173
var subplotCalcData = [];

0 commit comments

Comments
 (0)