fix bullet with range spanning negative values

antoinerg · antoinerg · commit 3b9028a424fa · 2019-07-05T15:29:41.000-04:00
diff --git a/src/traces/indicator/plot.js b/src/traces/indicator/plot.js
@@ -282,7 +282,7 @@ function drawBulletGauge(gd, plotGroup, cd, gaugeOpts) {
 
     function drawRect(s) {
         s
-            .attr('width', function(d) { return Math.max(0, ax.c2p(d.range[1] - d.range[0]));})
+            .attr('width', function(d) { return Math.max(0, ax.c2p(d.range[1]) - ax.c2p(d.range[0]));})
             .attr('x', function(d) { return ax.c2p(d.range[0]);})
             .attr('y', function(d) { return 0.5 * (1 - d.thickness) * bulletHeight;})
             .attr('height', function(d) { return d.thickness * bulletHeight; });

Original file line number	Diff line number	Diff line change
`@@ -282,7 +282,7 @@ function drawBulletGauge(gd, plotGroup, cd, gaugeOpts) {`
`282`	`282`
`283`	`283`	`function drawRect(s) {`
`284`	`284`	`s`
`285`		`- .attr('width', function(d) { return Math.max(0, ax.c2p(d.range[1] - d.range[0]));})`
	`285`	`+ .attr('width', function(d) { return Math.max(0, ax.c2p(d.range[1]) - ax.c2p(d.range[0]));})`
`286`	`286`	`.attr('x', function(d) { return ax.c2p(d.range[0]);})`
`287`	`287`	`.attr('y', function(d) { return 0.5 * (1 - d.thickness) * bulletHeight;})`
`288`	`288`	`.attr('height', function(d) { return d.thickness * bulletHeight; });`