Fix single-color open markers

Author: dy

package.json

@@ -59,7 +59,8 @@
     "alpha-shape": "^1.0.0",
     "bubleify": "^1.0.0",
     "canvas-fit": "^1.5.0",
-    "color-rgba": "^1.1.1",
+    "color-normalize": "^1.0.2",
+    "color-rgba": "^2.0.0",
     "convex-hull": "^1.0.3",
     "country-regex": "^1.1.0",
     "d3": "^3.5.12",

src/lib/gl_format_color.js

@@ -10,7 +10,7 @@
 'use strict';
 
 var isNumeric = require('fast-isnumeric');
-var rgba = require('color-rgba');
+var rgba = require('color-normalize');
 
 var Colorscale = require('../components/colorscale');
 var colorDflt = require('../components/color/attributes').defaultLine;

src/traces/scattergl/defaults.js

@@ -27,6 +27,9 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
         return Lib.coerce(traceIn, traceOut, attributes, attr, dflt);
     }
 
+    var isOpen = traceIn.marker ? /-open/.test(traceIn.marker.symbol) : false;
+    var isBubble = subTypes.isBubble(traceIn);
+
     var len = handleXYDefaults(traceIn, traceOut, layout, coerce);
     if(!len) {
         traceOut.visible = false;
@@ -45,6 +48,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
 
     if(subTypes.hasMarkers(traceOut)) {
         handleMarkerDefaults(traceIn, traceOut, defaultColor, layout, coerce);
+        coerce('marker.line.width', isOpen || isBubble ? 1 : 0);
         dfltHoverOn.push('points');
     }
 

src/traces/scattergl/index.js

@@ -25,6 +25,7 @@ var linkTraces = require('../scatter/link_traces');
 var createScatter = require('regl-scatter2d');
 var createLine = require('regl-line2d');
 var createError = require('regl-error2d');
+var rgba = require('color-normalize');
 var svgSdf = require('svg-path-sdf');
 var createRegl = require('regl');
 var fillHoverText = require('../scatter/fill_hover_text');
@@ -405,6 +406,7 @@ ScatterGl.sceneOptions = function sceneOptions(container, subplot, trace, positi
         if(!multiMarker) {
             isOpen = /-open/.test(markerOpts.symbol);
         }
+
         // prepare colors
         if(multiMarker || Array.isArray(markerOpts.color) || Array.isArray(markerOpts.line.color) || Array.isArray(markerOpts.line) || Array.isArray(markerOpts.opacity)) {
             markerOptions.colors = new Array(count);
@@ -445,15 +447,17 @@ ScatterGl.sceneOptions = function sceneOptions(container, subplot, trace, positi
             markerOptions.opacity = trace.opacity;
         }
         else {
-            markerOptions.color = markerOpts.color;
-            markerOptions.borderColor = markerOpts.line.color;
-            markerOptions.opacity = trace.opacity * markerOpts.opacity;
-
             if(isOpen) {
-                markerOptions.borderColor = markerOptions.color.slice();
-                markerOptions.color = markerOptions.color.slice();
+                markerOptions.color = rgba(markerOpts.color, 'uint8');
                 markerOptions.color[3] = 0;
+                markerOptions.borderColor = rgba(markerOpts.color, 'uint8');
             }
+            else {
+                markerOptions.color = rgba(markerOpts.color, 'uint8');
+                markerOptions.borderColor = rgba(markerOpts.line.color, 'uint8');
+            }
+
+            markerOptions.opacity = trace.opacity * markerOpts.opacity;
         }
 
         // prepare markers