rename to _indexToPoints

Author: monfera

src/transforms/aggregate.js

@@ -218,12 +218,12 @@ exports.calcTransform = function(gd, trace, opts) {
     var i, vi, groupIndex, newGrouping;
 
     var groupIndices = {};
-    var indexToPoints = {};
+    var _indexToPoints = {};
     var groupings = [];
 
-    var prevTransforms = trace.transforms.filter(function(tr) {return tr.indexToPoints;});
+    var prevTransforms = trace.transforms.filter(function(tr) {return tr._indexToPoints;});
     var originalPointsAccessor = prevTransforms.length ?
-        function(i) {return prevTransforms[prevTransforms.length - 1].indexToPoints[i];} :
+        function(i) {return prevTransforms[prevTransforms.length - 1]._indexToPoints[i];} :
         function(i) {return [i];};
 
     for(i = 0; i < groupArray.length; i++) {
@@ -233,15 +233,15 @@ exports.calcTransform = function(gd, trace, opts) {
             groupIndices[vi] = groupings.length;
             newGrouping = [i];
             groupings.push(newGrouping);
-            indexToPoints[groupIndices[vi]] = originalPointsAccessor(i);
+            _indexToPoints[groupIndices[vi]] = originalPointsAccessor(i);
         }
         else {
             groupings[groupIndex].push(i);
-            indexToPoints[groupIndices[vi]] = indexToPoints[groupIndices[vi]].concat(originalPointsAccessor(i));
+            _indexToPoints[groupIndices[vi]] = _indexToPoints[groupIndices[vi]].concat(originalPointsAccessor(i));
         }
     }
 
-    opts.indexToPoints = indexToPoints;
+    opts._indexToPoints = _indexToPoints;
 
     var aggregations = opts.aggregations;
 

src/transforms/filter.js

@@ -170,7 +170,7 @@ exports.calcTransform = function(gd, trace, opts) {
     var d2c = Axes.getDataToCoordFunc(gd, trace, target, targetArray);
     var filterFunc = getFilterFunc(opts, d2c, targetCalendar);
     var originalArrays = {};
-    var indexToPoints = {};
+    var _indexToPoints = {};
     var index = 0;
 
     function forAllAttrs(fn, index) {
@@ -205,21 +205,21 @@ exports.calcTransform = function(gd, trace, opts) {
     // copy all original array attribute values, and clear arrays in trace
     forAllAttrs(initFn);
 
-    var prevTransforms = trace.transforms.filter(function(tr) {return tr.indexToPoints;});
+    var prevTransforms = trace.transforms.filter(function(tr) {return tr._indexToPoints;});
     var originalPointsAccessor = prevTransforms.length ?
-        function(i) {return prevTransforms[prevTransforms.length - 1].indexToPoints[i];} :
+        function(i) {return prevTransforms[prevTransforms.length - 1]._indexToPoints[i];} :
         function(i) {return [i];};
 
     // loop through filter array, fill trace arrays if passed
     for(var i = 0; i < len; i++) {
         var passed = filterFunc(targetArray[i]);
         if(passed) {
             forAllAttrs(fillFn, i);
-            indexToPoints[index++] = originalPointsAccessor(i);
+            _indexToPoints[index++] = originalPointsAccessor(i);
         }
     }
 
-    opts.indexToPoints = indexToPoints;
+    opts._indexToPoints = _indexToPoints;
 };
 
 function getFilterFunc(opts, d2c, targetCalendar) {

test/jasmine/tests/transform_aggregate_test.js

@@ -61,7 +61,7 @@ describe('aggregate', function() {
         expect(traceOut.marker.line.width).toEqual([4, 1]);
 
         var transform = traceOut.transforms[0];
-        var inverseMapping = transform.indexToPoints;
+        var inverseMapping = transform._indexToPoints;
         expect(inverseMapping).toEqual({0: [0, 2, 3, 4], 1: [1]});
     });
 
@@ -169,7 +169,7 @@ describe('aggregate', function() {
         expect(traceOut.text).toEqual(['b', 'b']);
 
         var transform = traceOut.transforms[0];
-        var inverseMapping = transform.indexToPoints;
+        var inverseMapping = transform._indexToPoints;
         expect(inverseMapping).toEqual({0: [0, 1], 1: [2, 3]});
     });
 
@@ -195,7 +195,7 @@ describe('aggregate', function() {
         expect(traceOut.marker.size).toEqual([10, 20]);
 
         var transform = traceOut.transforms[0];
-        var inverseMapping = transform.indexToPoints;
+        var inverseMapping = transform._indexToPoints;
         expect(inverseMapping).toEqual({0: [0, 1, 4], 1: [2, 3]});
     });
 
@@ -217,7 +217,7 @@ describe('aggregate', function() {
         expect(traceOut.marker.size).toEqual([10, 20]);
 
         var transform = traceOut.transforms[0];
-        var inverseMapping = transform.indexToPoints;
+        var inverseMapping = transform._indexToPoints;
         expect(inverseMapping).toEqual({0: [0, 1, 4], 1: [2, 3]});
     });
 

test/jasmine/tests/transform_filter_test.js

@@ -143,7 +143,7 @@ describe('filter transforms calc:', function() {
         expect(out[0].x).toEqual([0, 1]);
         expect(out[0].y).toEqual([1, 2]);
         expect(out[0].z).toEqual(['2016-10-21', '2016-12-02']);
-        expect(out[0].transforms[0].indexToPoints).toEqual({0: [3], 1: [4]});
+        expect(out[0].transforms[0]._indexToPoints).toEqual({0: [3], 1: [4]});
     });
 
     it('should use the calendar from the target attribute if target is a string', function() {
@@ -262,7 +262,7 @@ describe('filter transforms calc:', function() {
         expect(out[0].x).toEqual([-2, 2, 3]);
         expect(out[0].y).toEqual([3, 3, 1]);
         expect(out[0].marker.color).toEqual([0.3, 0.3, 0.4]);
-        expect(out[0].transforms[0].indexToPoints).toEqual({0: [2], 1: [5], 2: [6]});
+        expect(out[0].transforms[0]._indexToPoints).toEqual({0: [2], 1: [5], 2: [6]});
     });
 
     it('filters should handle array on base trace attributes', function() {
@@ -316,8 +316,8 @@ describe('filter transforms calc:', function() {
 
         expect(out[0].x).toEqual([1, 2]);
         expect(out[0].y).toEqual([2, 3]);
-        expect(out[0].transforms[0].indexToPoints).toEqual({0: [4], 1: [5], 2: [6]});
-        expect(out[0].transforms[1].indexToPoints).toEqual({0: [4], 1: [5]});
+        expect(out[0].transforms[0]._indexToPoints).toEqual({0: [4], 1: [5], 2: [6]});
+        expect(out[0].transforms[1]._indexToPoints).toEqual({0: [4], 1: [5]});
     });
 
     it('filters should chain as AND (case 2)', function() {
@@ -343,8 +343,8 @@ describe('filter transforms calc:', function() {
 
         expect(out[0].x).toEqual([3]);
         expect(out[0].y).toEqual([1]);
-        expect(out[0].transforms[0].indexToPoints).toEqual({0: [4], 1: [5], 2: [6]});
-        expect(out[0].transforms[2].indexToPoints).toEqual({0: [6]});
+        expect(out[0].transforms[0]._indexToPoints).toEqual({0: [4], 1: [5], 2: [6]});
+        expect(out[0].transforms[2]._indexToPoints).toEqual({0: [6]});
     });
 
     it('should preserve gaps in data when `preservegaps` is turned on', function() {

test/jasmine/tests/transform_multi_test.js

@@ -322,9 +322,9 @@ describe('multiple transforms:', function() {
             expect(gd._fullData[0].y).toEqual([9]);
             expect(gd._fullData[0].marker.size).toEqual([10]);
 
-            expect(gd._fullData[0].transforms[0].indexToPoints).toEqual({0: [1], 1: [3], 2: [4]});
-            expect(gd._fullData[0].transforms[1].indexToPoints).toEqual({0: [1, 3], 1: [4]});
-            expect(gd._fullData[0].transforms[2].indexToPoints).toEqual({0: [4]});
+            expect(gd._fullData[0].transforms[0]._indexToPoints).toEqual({0: [1], 1: [3], 2: [4]});
+            expect(gd._fullData[0].transforms[1]._indexToPoints).toEqual({0: [1, 3], 1: [4]});
+            expect(gd._fullData[0].transforms[2]._indexToPoints).toEqual({0: [4]});
 
             done();
         });