Close #1920: group_by.plotly() now retains crosstalk set information

Author: cpsievert

R/plotly_data.R

@@ -131,9 +131,9 @@ ungroup.plotly <- function(x, ...) {
 
 #' @rdname plotly_data
 group_by.plotly <- function(.data, ...) {
-  d <- group_by(plotly_data(.data), ...)
+  d <- preserve_set(plotly_data(.data), group_by, ...)
   if (crosstalk_key() %in% names(d)) {
-    d <- group_by_add(d, !!rlang::sym(crosstalk_key()), add = TRUE)
+    d <- preserve_set(d, group_by_add, !!rlang::sym(crosstalk_key()))
   }
   add_data(.data, d)
 }

tests/testthat/test-animate-highlight.R

@@ -70,6 +70,18 @@ test_that("Simple scatterplot brushing with plot_ly() and subplot()", {
 })
 
 
+test_that("group_by.plotly() retains crosstalk set", {
+  b <- mtcars %>%
+    crosstalk::SharedData$new(group = "foo") %>%
+    plot_ly(x = ~mpg, y = ~hp) %>%
+    group_by(am) %>%
+    add_markers() %>%
+    plotly_build()
+  expect_equal(b$x$data[[1]]$set, "foo")
+  expect_true(all(b$x$data[[1]]$key == row.names(mtcars)))
+})
+
+
 
 # Ignore for now https://github.com/ggobi/ggally/issues/264
 #test_that("SharedData produces key/set in ggpairs", {